Paths

Table of Contentst

Differential D20410

Remove legacy "DashboardInstall" table
ClosedPublic
Actions

Authored by epriestley on Apr 12 2019, 7:24 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Sep 6, 6:10 AM

	Unknown Object (File)
	Sun, Aug 25, 8:41 AM

	Unknown Object (File)
	Sat, Aug 24, 9:32 AM

	Unknown Object (File)
	Sat, Aug 24, 9:31 AM

	Unknown Object (File)
	Sat, Aug 24, 9:31 AM

	Unknown Object (File)
	Sat, Aug 24, 8:40 AM

	Unknown Object (File)
	Thu, Aug 22, 1:21 AM

	Unknown Object (File)
	Jul 26 2024, 11:41 PM

Subscribers

Restricted Owners Package

Details

Reviewers

Maniphest Tasks

T13272: Remove the hard-coded homepage, and other Dashboards improvements

Commits

rP80b7274e0bf6: Remove legacy "DashboardInstall" table

Summary

Depends on D20409. Ref T13272. Before "ProfileMenu", dashboards were installed on specific objects using this table. Installs are now handled via ProfileMenu and this table no longer has any meaningful readers. Remove references to the table and destroy it.

Test Plan

Grepped for DashboardInstall.

Diff Detail

Repository

Branch

panel12

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22572
Build 30916: Run Core Tests
Build 30915: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 12 2019, 7:24 PM

Owners added a subscriber: Restricted Owners Package.Apr 12 2019, 7:24 PM

Harbormaster completed remote builds in B22572: Diff 48702.Apr 12 2019, 7:26 PM

epriestley requested review of this revision.Apr 12 2019, 7:26 PM

epriestley added a child revision: D20411: Update search indexes for Dashboards and Panels to Ferret, plus various minor fixes.Apr 12 2019, 8:06 PM

amckinley accepted this revision.Apr 12 2019, 9:47 PM

This revision is now accepted and ready to land.Apr 12 2019, 9:47 PM

Closed by commit rP80b7274e0bf6: Remove legacy "DashboardInstall" table (authored by epriestley). · Explain WhyApr 14 2019, 5:27 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20190412.dashboard.02.install.sql

1 line

src/

__phutil_library_map__.php

applications/

dashboard/

storage/

PhabricatorDashboard.php

12 lines

PhabricatorDashboardInstall.php

guides/

module/

PhabricatorGuideQuickStartModule.php

27 lines

Diff 48702

resources/sql/autopatches/20190412.dashboard.02.install.sql

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/dashboard/storage/PhabricatorDashboard.php

Loading...

src/applications/dashboard/storage/PhabricatorDashboardInstall.php

Loading...

src/applications/guides/module/PhabricatorGuideQuickStartModule.php

Loading...