Page MenuHomePhabricator

Fix rendering of offset-paged query panels including "Notifications"
ClosedPublic

Authored by epriestley on Apr 2 2019, 12:45 PM.

Details

Summary

See https://discourse.phabricator-community.org/t/call-to-undefined-method-phuipagerview-gethasmoreresults-in-2019-week-13/2586/.

A small number of queries (including "Notifications" and (global) "Search") use offset-based pagers which have a slightly different API PHUIPagerView instead of AphrontCursorPagerView. This leads to a fatal in the new code for the "View All Results" buttons.

To fix this, just do an instanceof test. Some day we can unify the pagers.

Test Plan

Added a notifications panel, rendered it, saw it work instead of fataling on "getHasMoreResults()". Also rendered some normal panels.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Apr 2 2019, 12:45 PM
epriestley requested review of this revision.Apr 2 2019, 12:47 PM
amckinley accepted this revision.Apr 3 2019, 6:43 PM
This revision is now accepted and ready to land.Apr 3 2019, 6:43 PM
This revision was automatically updated to reflect the committed changes.