Page MenuHomePhabricator

Raise a more tailored exception if transform/thumbnail support is missing for cover images
ClosedPublic

Authored by epriestley on Mar 26 2019, 9:24 PM.

Details

Summary

If "GD" doesn't support a particular image type, applying a cover image currently goes through but no-ops. Fail it earlier in the process with a more specific error.

Test Plan

Without PNG support locally, dropped a PNG onto a card on a workboard. Got a more useful error.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mar 26 2019, 9:24 PM
epriestley requested review of this revision.Mar 26 2019, 9:26 PM
amckinley accepted this revision.Mar 26 2019, 9:42 PM
This revision is now accepted and ready to land.Mar 26 2019, 9:42 PM
This revision was automatically updated to reflect the committed changes.