Page MenuHomePhabricator
Differential D20328

Raise a more tailored exception if transform/thumbnail support is missing for cover images
ClosedPublic
Actions

Authored by epriestley on Mar 26 2019, 9:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 16, 7:20 PM
Unknown Object (File)
Mon, Jun 16, 6:32 PM
Unknown Object (File)
Sun, Jun 15, 8:42 AM
Unknown Object (File)
Jun 6 2025, 7:04 AM
Unknown Object (File)
May 7 2025, 12:50 AM
Unknown Object (File)
Apr 14 2025, 5:04 PM
Unknown Object (File)
Apr 13 2025, 6:47 PM
Unknown Object (File)
Apr 12 2025, 5:00 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rPb328af0a1b16: Raise a more tailored exception if transform/thumbnail support is missing for…
Summary

If "GD" doesn't support a particular image type, applying a cover image currently goes through but no-ops. Fail it earlier in the process with a more specific error.

Test Plan

Without PNG support locally, dropped a PNG onto a card on a workboard. Got a more useful error.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
xaction/
36 lines

Diff 48522

View Options

src/applications/maniphest/xaction/ManiphestTaskCoverImageTransaction.php

Loading...
Phabricator · Built by Phacility