Page MenuHomePhabricator

Raise a more tailored exception if transform/thumbnail support is missing for cover images
ClosedPublic

Authored by epriestley on Mar 26 2019, 9:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 15, 2:35 AM
Unknown Object (File)
Wed, Jan 29, 7:54 PM
Unknown Object (File)
Jan 18 2025, 3:34 AM
Unknown Object (File)
Dec 28 2024, 3:16 PM
Unknown Object (File)
Dec 28 2024, 2:50 PM
Unknown Object (File)
Dec 24 2024, 3:42 PM
Unknown Object (File)
Dec 19 2024, 12:59 AM
Unknown Object (File)
Dec 13 2024, 3:43 PM
Subscribers
None

Details

Summary

If "GD" doesn't support a particular image type, applying a cover image currently goes through but no-ops. Fail it earlier in the process with a more specific error.

Test Plan

Without PNG support locally, dropped a PNG onto a card on a workboard. Got a more useful error.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable