Page MenuHomePhabricator
Differential D20328

Raise a more tailored exception if transform/thumbnail support is missing for cover images
ClosedPublic
Actions

Authored by epriestley on Mar 26 2019, 9:24 PM.
Tags
None
Referenced Files
F19901641: D20328.id48521.diff
Mon, Mar 30, 10:59 AM
F19707990: D20328.id.diff
Feb 11 2026, 12:19 PM
F19507303: D20328.id48521.diff
Jan 9 2026, 7:15 PM
F19503798: D20328.diff
Jan 9 2026, 1:44 AM
F18877640: D20328.id.diff
Nov 6 2025, 11:08 AM
F18873126: D20328.diff
Nov 5 2025, 8:07 AM
F18780413: D20328.id48521.diff
Oct 12 2025, 12:16 PM
F18751488: D20328.id.diff
Oct 4 2025, 11:21 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rPb328af0a1b16: Raise a more tailored exception if transform/thumbnail support is missing for…
Summary

If "GD" doesn't support a particular image type, applying a cover image currently goes through but no-ops. Fail it earlier in the process with a more specific error.

Test Plan

Without PNG support locally, dropped a PNG onto a card on a workboard. Got a more useful error.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
xaction/
36 lines

Diff 48522

View Options

src/applications/maniphest/xaction/ManiphestTaskCoverImageTransaction.php

Loading...
Phabricator · Built by Phacility