Page MenuHomePhabricator

Pass all adjacent card PHIDs from the client to the server when moving a card
ClosedPublic

Authored by epriestley on Mar 25 2019, 7:17 PM.
Tags
None
Referenced Files
F13200523: D20322.diff
Tue, May 14, 1:13 AM
Unknown Object (File)
Mon, May 6, 7:08 AM
Unknown Object (File)
Fri, Apr 19, 3:06 AM
Unknown Object (File)
Fri, Apr 19, 3:06 AM
Unknown Object (File)
Fri, Apr 19, 3:06 AM
Unknown Object (File)
Apr 11 2024, 4:15 AM
Unknown Object (File)
Apr 4 2024, 6:03 AM
Unknown Object (File)
Apr 2 2024, 5:04 PM
Subscribers
None

Details

Summary

Depends on D20321. Fixes T12175. Ref T13074. Now that before/after PHIDs are suggestions, we can give the server a more complete view of what the client is trying to do so we're more likely to get a good outcome if the client view is out of date.

Instead of passing only the one directly adjacent card PHID, pass all the card PHIDs that the client thinks are in the same group.

(For gigantic columns with tens of thousands of tasks this might need some tweaking -- like, slice both lists down to 10 items -- but we can cross that bridge when we come to it.)

Test Plan
  • Dragged some cards around to top/bottom/middle positions, saw good positioning in all cases.
  • In two windows, dragged stuff around on the same board. At least at first glance, conflicting simultaneous edits seemed to do reasonable things.

Diff Detail

Repository
rP Phabricator
Branch
trigger16
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22363
Build 30599: Run Core Tests
Build 30598: arc lint + arc unit