Page MenuHomePhabricator
Differential D20302

Write workboard trigger rules to the database
ClosedPublic
Actions

Authored by epriestley on Mar 21 2019, 6:52 PM.
Tags
None
Referenced Files
F14844424: D20302.diff
Sun, Feb 2, 3:49 PM
Unknown Object (File)
Thu, Jan 30, 9:16 AM
Unknown Object (File)
Wed, Jan 29, 3:37 PM
Unknown Object (File)
Wed, Jan 29, 9:04 AM
Unknown Object (File)
Sat, Jan 25, 4:18 AM
Unknown Object (File)
Sat, Jan 25, 4:18 AM
Unknown Object (File)
Sat, Jan 25, 4:18 AM
Unknown Object (File)
Tue, Jan 21, 3:43 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T5474: Support workboard column triggers which activate when a task is dropped into a column
Commits
rPff128e1b3244: Write workboard trigger rules to the database
Summary

Ref T5474. Read and write trigger rules so users can actually edit them.

Test Plan

Added, modified, and removed trigger rules. Saved changes, used "Show Details" to review edits.

Diff Detail

Repository
rP Phabricator
Branch
trigger8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22320
Build 30532: Run Core Tests
Build 30531: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 21 2019, 6:52 PM
Harbormaster completed remote builds in B22320: Diff 48456.Mar 21 2019, 6:53 PM
epriestley requested review of this revision.Mar 21 2019, 6:53 PM
amckinley accepted this revision.Mar 25 2019, 7:49 PM
amckinley added inline comments.
src/applications/project/storage/PhabricatorProjectTrigger.php
91

"ha ve"

This revision is now accepted and ready to land.Mar 25 2019, 7:49 PM
Closed by commit rPff128e1b3244: Write workboard trigger rules to the database (authored by epriestley). · Explain WhyMar 25 2019, 8:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
project/
controller/
trigger/
20 lines
storage/
186 lines
xaction/
trigger/
65 lines

Diff 48456

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/project/controller/trigger/PhabricatorProjectTriggerEditController.php

Loading...
View Options

src/applications/project/storage/PhabricatorProjectTrigger.php

Loading...
View Options

src/applications/project/xaction/trigger/PhabricatorProjectTriggerRulesetTransaction.php

Loading...
Phabricator · Built by Phacility