Differential D20271

When creating or editing a card on a sorted/grouped workboard, adjust headers appropriately
ClosedPublic
Actions

Authored by epriestley on Mar 11 2019, 5:12 AM.

Details

Reviewers

amckinley

Maniphest Tasks

T10333: Add groups to workboard columns

Commits

rP21dd79b35af2: When creating or editing a card on a sorted/grouped workboard, adjust headers…

Summary

Depends on D20270. Ref T10333. If you create a task with a new owner, or edit a task and change the priority/owner, we want to move it (and possibly create a new header) when the response comes back.

Make sure the response includes the appropriate details about the object's header and position.

Test Plan

Grouped by Owner.
Created a new task with a new owner, saw the header appear.
Edited a task and changed it to give it a new owner, saw the header appear.

Diff Detail

Repository

rP Phabricator

Branch

grip7

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22249
Build 30423: Run Core Tests
Build 30422: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 11 2019, 5:12 AM

Harbormaster completed remote builds in B22249: Diff 48386.Mar 11 2019, 5:14 AM

epriestley requested review of this revision.Mar 11 2019, 5:14 AM

epriestley added a child revision: D20272: Improve rendering of empty workboard columns in header views.Mar 11 2019, 5:26 AM

amckinley accepted this revision.Mar 12 2019, 8:02 PM

This revision is now accepted and ready to land.Mar 12 2019, 8:02 PM

epriestley added inline comments.Mar 12 2019, 8:03 PM

src/applications/maniphest/controller/ManiphestController.php
40	(This lost all its callers when I got rid of the global list-view drag-and-drop priority behavior in D20263, it just didn't get cleaned up in that change.)