Page MenuHomePhabricator

When creating or editing a card on a sorted/grouped workboard, adjust headers appropriately
ClosedPublic

Authored by epriestley on Mar 11 2019, 5:12 AM.

Details

Summary

Depends on D20270. Ref T10333. If you create a task with a new owner, or edit a task and change the priority/owner, we want to move it (and possibly create a new header) when the response comes back.

Make sure the response includes the appropriate details about the object's header and position.

Test Plan
  • Grouped by Owner.
  • Created a new task with a new owner, saw the header appear.
  • Edited a task and changed it to give it a new owner, saw the header appear.

Diff Detail

Repository
rP Phabricator
Branch
grip7
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 22249
Build 30423: Run Core Tests
Build 30422: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 11 2019, 5:12 AM
epriestley requested review of this revision.Mar 11 2019, 5:14 AM
amckinley accepted this revision.Mar 12 2019, 8:02 PM
This revision is now accepted and ready to land.Mar 12 2019, 8:02 PM
epriestley added inline comments.Mar 12 2019, 8:03 PM
src/applications/maniphest/controller/ManiphestController.php
40

(This lost all its callers when I got rid of the global list-view drag-and-drop priority behavior in D20263, it just didn't get cleaned up in that change.)

This revision was automatically updated to reflect the committed changes.