Page MenuHomePhabricator
Differential D20210

Make the Diffusion warning about "svnlook" and PATH more clear
ClosedPublic
Actions

Authored by epriestley on Feb 25 2019, 2:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 28, 1:04 AM
Unknown Object (File)
Sun, Jan 26, 8:27 AM
Unknown Object (File)
Wed, Jan 22, 7:57 PM
Unknown Object (File)
Wed, Jan 22, 10:01 AM
Unknown Object (File)
Thu, Jan 16, 8:28 PM
Unknown Object (File)
Dec 19 2024, 7:06 PM
Unknown Object (File)
Dec 10 2024, 6:18 PM
Unknown Object (File)
Dec 7 2024, 11:07 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rPf61e825905c1: Make the Diffusion warning about "svnlook" and PATH more clear
Summary

See https://discourse.phabricator-community.org/t/display-error-on-the-status-page-for-svn-repos/2443 for discussion.

The UI currently shows a misleading warning that looks like "found svnlook; can't find svnlook".

It actually means "found svnlook, but when Subversion wipes PATH before executing commit hooks, we will no longer be able to find it".

Test Plan

Screen Shot 2019-02-25 at 6.16.46 AM.png (60×952 px, 27 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
management/
16 lines

Diff 48255

View Options

src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php

Loading...
Phabricator · Built by Phacility