Page MenuHomePhabricator

Remove some ancient daemon log code
ClosedPublic

Authored by epriestley on Feb 20 2019, 5:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 5:36 PM
Unknown Object (File)
Thu, Nov 14, 6:43 PM
Unknown Object (File)
Oct 19 2024, 4:49 PM
Unknown Object (File)
Oct 18 2024, 4:50 PM
Unknown Object (File)
Oct 18 2024, 10:42 AM
Unknown Object (File)
Oct 16 2024, 11:28 PM
Unknown Object (File)
Oct 16 2024, 3:37 PM
Unknown Object (File)
Oct 6 2024, 7:07 AM
Subscribers
None

Details

Summary

Ref T13253. Long ago, daemon logs were visible in the web UI. They were removed because access to logs generally does not conform to policy rules, and may leak the existence (and sometimes contents) of hidden objects, occasionally leak credentials in certain error messages, etc.

These bits and pieces were missed.

Test Plan

Grepped for removed symbols.

Diff Detail

Repository
rP Phabricator
Branch
daemon1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22083
Build 30166: Run Core Tests
Build 30165: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Feb 20 2019, 5:51 PM
This revision was automatically updated to reflect the committed changes.