Differential D20097

Improve feed rendering of user rename story
ClosedPublic
Actions

Authored by epriestley on Feb 5 2019, 3:19 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Mar 31, 10:19 PM

	Unknown Object (File)
	Sun, Mar 31, 9:42 AM

	Unknown Object (File)
	Mar 10 2024, 6:18 PM

	Unknown Object (File)
	Feb 10 2024, 6:49 AM

	Unknown Object (File)
	Feb 8 2024, 5:09 PM

	Unknown Object (File)
	Feb 8 2024, 1:55 PM

	Unknown Object (File)
	Feb 8 2024, 1:48 PM

	Unknown Object (File)
	Feb 8 2024, 1:28 PM

View All 72 Files

Subscribers

None

Details

Reviewers

amckinley

Maniphest Tasks

T13244: 2019 Week 6 Bonus Content

Commits

rPab467d52f4dd: Improve feed rendering of user rename story

Summary

Ref T13244. This story publishes to the feed (and I think that's reasonable and desirable) but doesn't render as nicely as it could.

Improve the rendering.

(See T9233 for some context on why we render stories like this one in this way.)

Test Plan

Screen Shot 2019-02-05 at 7.16.48 AM.png (767×1 px, 144 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 5 2019, 3:19 PM

Harbormaster completed remote builds in B21828: Diff 47985.Feb 5 2019, 3:20 PM

epriestley requested review of this revision.Feb 5 2019, 3:20 PM

amckinley accepted this revision.Feb 5 2019, 9:00 PM

This revision is now accepted and ready to land.Feb 5 2019, 9:00 PM

Closed by commit rPab467d52f4dd: Improve feed rendering of user rename story (authored by epriestley). · Explain WhyFeb 5 2019, 10:13 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

xaction/

PhabricatorUserUsernameTransaction.php

9 lines

Diff 48000

View Options

src/applications/people/xaction/PhabricatorUserUsernameTransaction.php

Improve feed rendering of user rename storyClosedPublicActions