Page MenuHomePhabricator

Give Duo MFA a stronger hint if users continue without answering the challenge
ClosedPublic

Authored by epriestley on Feb 5 2019, 2:41 AM.

Details

Summary

See PHI912. Also, clean up some leftover copy/pastey code here.

Test Plan

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 5 2019, 2:41 AM
epriestley added inline comments.Feb 5 2019, 2:43 AM
src/applications/auth/factor/PhabricatorDuoAuthFactor.php
678–712

This stuff came from SMS/TOTP but isn't relevant for Duo. We have to return an empty result to make some other code work, although perhaps some future followup could simplify this a bit further.

epriestley requested review of this revision.Feb 5 2019, 2:43 AM
amckinley accepted this revision.Feb 5 2019, 8:08 PM
This revision is now accepted and ready to land.Feb 5 2019, 8:08 PM
This revision was automatically updated to reflect the committed changes.