Differential D20029

Fix bad "$this" references in "Must Encrypt" mail after MailEngine changes
ClosedPublic
Actions

Authored by epriestley on Jan 24 2019, 11:00 PM.

Tags

None

Referenced Files

	F18773694: D20029.diff
	Thu, Oct 9, 11:58 AM

	F18767853: D20029.id47831.diff
	Wed, Oct 8, 12:32 AM

	F18649642: D20029.id.diff
	Sep 20 2025, 9:43 PM

	F18645990: D20029.diff
	Sep 19 2025, 9:00 AM

	F18566920: D20029.id.diff
	Sep 9 2025, 3:00 PM

	F18170282: D20029.id47832.diff
	Aug 15 2025, 5:57 PM

	F18132371: D20029.id.diff
	Aug 13 2025, 9:16 PM

	F18111279: D20029.diff
	Aug 12 2025, 9:56 AM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rP9cf0d58e5da0: (stable) Fix bad "$this" references in "Must Encrypt" mail after MailEngine…
rP5cfcef7f535c: Fix bad "$this" references in "Must Encrypt" mail after MailEngine changes

Summary

See PHI1038. I missed these when pulling the code out.

Test Plan

Sent "Must encrypt" mail, verified it made it through the queue in one piece.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 24 2019, 11:00 PM

Harbormaster completed remote builds in B21684: Diff 47831.Jan 24 2019, 11:02 PM

epriestley requested review of this revision.Jan 24 2019, 11:02 PM

amckinley accepted this revision.Jan 24 2019, 11:04 PM

This revision is now accepted and ready to land.Jan 24 2019, 11:04 PM

Closed by commit rP5cfcef7f535c: Fix bad "$this" references in "Must Encrypt" mail after MailEngine changes (authored by epriestley). · Explain WhyJan 24 2019, 11:07 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

metamta/

engine/

PhabricatorMailEmailEngine.php

6 lines

Diff 47832

View Options

src/applications/metamta/engine/PhabricatorMailEmailEngine.php

Fix bad "$this" references in "Must Encrypt" mail after MailEngine changesClosedPublicActions