Paths

Table of Contentst

Differential D19979

Allow Phortune accounts to customize their billing address and name
ClosedPublic
Actions

Authored by epriestley on Jan 16 2019, 3:20 PM.

Tags

None

Referenced Files

	F15274863: D19979.diff
	Sat, Mar 1, 1:50 PM

	Unknown Object (File)
	Wed, Feb 26, 8:17 AM

	Unknown Object (File)
	Thu, Feb 20, 7:16 AM

	Unknown Object (File)
	Fri, Feb 14, 11:01 AM

	Unknown Object (File)
	Mon, Feb 10, 3:12 AM

	Unknown Object (File)
	Sun, Feb 9, 6:56 AM

	Unknown Object (File)
	Sun, Feb 9, 6:56 AM

	Unknown Object (File)
	Sun, Feb 9, 6:56 AM

Subscribers

Restricted Owners Package

Details

Reviewers

Maniphest Tasks

T7607: Invoicing emails probably need some work

Commits

rP6b6c991ad498: Allow Phortune accounts to customize their billing address and name

Summary

See PHI1023. Ref T7607. Occasionally, companies need their billing address (or some other custom text) to appear on invoices to satisfy process or compliance requirements.

Allow accounts to have a custom "Billing Name" and a custom "Billing Address" which appear on invoices.

Test Plan

Screen Shot 2019-01-16 at 6.58.51 AM.png (1×1 px, 224 KB)

Diff Detail

Repository

Branch

phortune1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21534
Build 29349: Run Core Tests
Build 29348: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 16 2019, 3:20 PM

Owners added a subscriber: Restricted Owners Package.Jan 16 2019, 3:20 PM

Harbormaster completed remote builds in B21534: Diff 47681.Jan 16 2019, 3:22 PM

epriestley requested review of this revision.Jan 16 2019, 3:22 PM

amckinley accepted this revision.Jan 17 2019, 12:07 AM

amckinley added inline comments.

src/applications/phortune/xaction/PhortuneAccountBillingNameTransaction.php
26–30	I'm guessing this works because "removing" the billing name is actually setting it to the empty string since the column is defined as `NOT NULL`?

This revision is now accepted and ready to land.Jan 17 2019, 12:07 AM

epriestley added inline comments.Jan 17 2019, 12:08 AM

src/applications/phortune/xaction/PhortuneAccountBillingNameTransaction.php
26–30	Yep.

Closed by commit rP6b6c991ad498: Allow Phortune accounts to customize their billing address and name (authored by epriestley). · Explain WhyJan 17 2019, 12:16 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

sql/

autopatches/

20190116.phortune.01.billing.sql

3 lines

src/

__phutil_library_map__.php

applications/

phortune/

controller/

cart/

PhortuneCartViewController.php

32 lines

editor/

PhortuneAccountEditEngine.php

19 lines

storage/

PhortuneAccount.php

6 lines

view/

PhortuneInvoiceView.php

2 lines

xaction/

PhortuneAccountBillingAddressTransaction.php

39 lines

PhortuneAccountBillingNameTransaction.php

56 lines

webroot/

rsrc/

css/

application/

phortune/

phortune-invoice.css

2 lines

Diff 47681

resources/celerity/map.php

Loading...

resources/sql/autopatches/20190116.phortune.01.billing.sql

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/phortune/controller/cart/PhortuneCartViewController.php

Loading...

src/applications/phortune/editor/PhortuneAccountEditEngine.php

Loading...

src/applications/phortune/storage/PhortuneAccount.php

Loading...

src/applications/phortune/view/PhortuneInvoiceView.php

Loading...

src/applications/phortune/xaction/PhortuneAccountBillingAddressTransaction.php

Loading...

src/applications/phortune/xaction/PhortuneAccountBillingNameTransaction.php

Loading...

webroot/rsrc/css/application/phortune/phortune-invoice.css

Loading...