Fix an issue where "CC"-only email improperly wiped CC addresses
ClosedPublic
Actions

Authored by epriestley on Jan 14 2019, 9:32 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T920: Provide SMS Support

Commits

rP96d3e73eed64: Fix an issue where "CC"-only email improperly wiped CC addresses

Summary

Ref T920. See https://discourse.phabricator-community.org/t/ccd-emails-not-working-with-sendgrid-since-2019-week-1-update/2294.

Test Plan

Used bin/mail send-test --cc ... without --to, got email.

Diff Detail

Repository

rP Phabricator

Branch

mfa14

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21521
Build 29324: Run Core Tests
Build 29323: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 14 2019, 9:32 PM

epriestley added inline comments.Jan 14 2019, 9:33 PM

src/applications/metamta/engine/PhabricatorMailEmailEngine.php
57	This was an incorrect leftover from the old logic which would sometimes move "CC" to "To".

Harbormaster completed remote builds in B21521: Diff 47668.Jan 14 2019, 9:35 PM

epriestley requested review of this revision.Jan 14 2019, 9:35 PM

amckinley accepted this revision.Jan 16 2019, 2:15 AM

This revision is now accepted and ready to land.Jan 16 2019, 2:15 AM

Closed by commit rP96d3e73eed64: Fix an issue where "CC"-only email improperly wiped CC addresses (authored by epriestley). · Explain WhyJan 16 2019, 9:22 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

metamta/

engine/

PhabricatorMailEmailEngine.php

1 line

Diff 47668

View Options

src/applications/metamta/engine/PhabricatorMailEmailEngine.php

Fix an issue where "CC"-only email improperly wiped CC addressesClosedPublicActions