diff --git a/src/applications/almanac/storage/AlmanacBinding.php b/src/applications/almanac/storage/AlmanacBinding.php --- a/src/applications/almanac/storage/AlmanacBinding.php +++ b/src/applications/almanac/storage/AlmanacBinding.php @@ -206,10 +206,6 @@ return new AlmanacBindingEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new AlmanacBindingTransaction(); } diff --git a/src/applications/almanac/storage/AlmanacDevice.php b/src/applications/almanac/storage/AlmanacDevice.php --- a/src/applications/almanac/storage/AlmanacDevice.php +++ b/src/applications/almanac/storage/AlmanacDevice.php @@ -204,10 +204,6 @@ return new AlmanacDeviceEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new AlmanacDeviceTransaction(); } diff --git a/src/applications/almanac/storage/AlmanacInterface.php b/src/applications/almanac/storage/AlmanacInterface.php --- a/src/applications/almanac/storage/AlmanacInterface.php +++ b/src/applications/almanac/storage/AlmanacInterface.php @@ -168,10 +168,6 @@ return new AlmanacInterfaceEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new AlmanacInterfaceTransaction(); } diff --git a/src/applications/almanac/storage/AlmanacNamespace.php b/src/applications/almanac/storage/AlmanacNamespace.php --- a/src/applications/almanac/storage/AlmanacNamespace.php +++ b/src/applications/almanac/storage/AlmanacNamespace.php @@ -191,10 +191,6 @@ return new AlmanacNamespaceEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new AlmanacNamespaceTransaction(); } diff --git a/src/applications/almanac/storage/AlmanacNetwork.php b/src/applications/almanac/storage/AlmanacNetwork.php --- a/src/applications/almanac/storage/AlmanacNetwork.php +++ b/src/applications/almanac/storage/AlmanacNetwork.php @@ -61,10 +61,6 @@ return new AlmanacNetworkEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new AlmanacNetworkTransaction(); } diff --git a/src/applications/almanac/storage/AlmanacService.php b/src/applications/almanac/storage/AlmanacService.php --- a/src/applications/almanac/storage/AlmanacService.php +++ b/src/applications/almanac/storage/AlmanacService.php @@ -226,10 +226,6 @@ return new AlmanacServiceEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new AlmanacServiceTransaction(); } diff --git a/src/applications/auth/storage/PhabricatorAuthPassword.php b/src/applications/auth/storage/PhabricatorAuthPassword.php --- a/src/applications/auth/storage/PhabricatorAuthPassword.php +++ b/src/applications/auth/storage/PhabricatorAuthPassword.php @@ -217,10 +217,6 @@ return new PhabricatorAuthPasswordEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorAuthPasswordTransaction(); } diff --git a/src/applications/auth/storage/PhabricatorAuthProviderConfig.php b/src/applications/auth/storage/PhabricatorAuthProviderConfig.php --- a/src/applications/auth/storage/PhabricatorAuthProviderConfig.php +++ b/src/applications/auth/storage/PhabricatorAuthProviderConfig.php @@ -91,10 +91,6 @@ return new PhabricatorAuthProviderConfigEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorAuthProviderConfigTransaction(); } diff --git a/src/applications/auth/storage/PhabricatorAuthSSHKey.php b/src/applications/auth/storage/PhabricatorAuthSSHKey.php --- a/src/applications/auth/storage/PhabricatorAuthSSHKey.php +++ b/src/applications/auth/storage/PhabricatorAuthSSHKey.php @@ -159,10 +159,6 @@ return new PhabricatorAuthSSHKeyEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorAuthSSHKeyTransaction(); } diff --git a/src/applications/badges/storage/PhabricatorBadgesBadge.php b/src/applications/badges/storage/PhabricatorBadgesBadge.php --- a/src/applications/badges/storage/PhabricatorBadgesBadge.php +++ b/src/applications/badges/storage/PhabricatorBadgesBadge.php @@ -125,10 +125,6 @@ return new PhabricatorBadgesEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorBadgesTransaction(); } diff --git a/src/applications/base/PhabricatorApplication.php b/src/applications/base/PhabricatorApplication.php --- a/src/applications/base/PhabricatorApplication.php +++ b/src/applications/base/PhabricatorApplication.php @@ -649,10 +649,6 @@ return new PhabricatorApplicationEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorApplicationApplicationTransaction(); } diff --git a/src/applications/calendar/storage/PhabricatorCalendarEvent.php b/src/applications/calendar/storage/PhabricatorCalendarEvent.php --- a/src/applications/calendar/storage/PhabricatorCalendarEvent.php +++ b/src/applications/calendar/storage/PhabricatorCalendarEvent.php @@ -1311,10 +1311,6 @@ return new PhabricatorCalendarEventEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorCalendarEventTransaction(); } diff --git a/src/applications/calendar/storage/PhabricatorCalendarExport.php b/src/applications/calendar/storage/PhabricatorCalendarExport.php --- a/src/applications/calendar/storage/PhabricatorCalendarExport.php +++ b/src/applications/calendar/storage/PhabricatorCalendarExport.php @@ -166,10 +166,6 @@ return new PhabricatorCalendarExportEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorCalendarExportTransaction(); } diff --git a/src/applications/calendar/storage/PhabricatorCalendarImport.php b/src/applications/calendar/storage/PhabricatorCalendarImport.php --- a/src/applications/calendar/storage/PhabricatorCalendarImport.php +++ b/src/applications/calendar/storage/PhabricatorCalendarImport.php @@ -140,10 +140,6 @@ return new PhabricatorCalendarImportEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorCalendarImportTransaction(); } diff --git a/src/applications/config/storage/PhabricatorConfigEntry.php b/src/applications/config/storage/PhabricatorConfigEntry.php --- a/src/applications/config/storage/PhabricatorConfigEntry.php +++ b/src/applications/config/storage/PhabricatorConfigEntry.php @@ -61,10 +61,6 @@ return new PhabricatorConfigEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorConfigTransaction(); } diff --git a/src/applications/conpherence/storage/ConpherenceThread.php b/src/applications/conpherence/storage/ConpherenceThread.php --- a/src/applications/conpherence/storage/ConpherenceThread.php +++ b/src/applications/conpherence/storage/ConpherenceThread.php @@ -311,10 +311,6 @@ return new ConpherenceEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new ConpherenceTransaction(); } diff --git a/src/applications/countdown/storage/PhabricatorCountdown.php b/src/applications/countdown/storage/PhabricatorCountdown.php --- a/src/applications/countdown/storage/PhabricatorCountdown.php +++ b/src/applications/countdown/storage/PhabricatorCountdown.php @@ -95,10 +95,6 @@ return new PhabricatorCountdownEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorCountdownTransaction(); } diff --git a/src/applications/dashboard/storage/PhabricatorDashboard.php b/src/applications/dashboard/storage/PhabricatorDashboard.php --- a/src/applications/dashboard/storage/PhabricatorDashboard.php +++ b/src/applications/dashboard/storage/PhabricatorDashboard.php @@ -130,10 +130,6 @@ return new PhabricatorDashboardTransactionEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorDashboardTransaction(); } diff --git a/src/applications/dashboard/storage/PhabricatorDashboardPanel.php b/src/applications/dashboard/storage/PhabricatorDashboardPanel.php --- a/src/applications/dashboard/storage/PhabricatorDashboardPanel.php +++ b/src/applications/dashboard/storage/PhabricatorDashboardPanel.php @@ -113,10 +113,6 @@ return new PhabricatorDashboardPanelTransactionEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorDashboardPanelTransaction(); } diff --git a/src/applications/differential/storage/DifferentialDiff.php b/src/applications/differential/storage/DifferentialDiff.php --- a/src/applications/differential/storage/DifferentialDiff.php +++ b/src/applications/differential/storage/DifferentialDiff.php @@ -699,10 +699,6 @@ return new DifferentialDiffEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new DifferentialDiffTransaction(); } diff --git a/src/applications/differential/storage/DifferentialRevision.php b/src/applications/differential/storage/DifferentialRevision.php --- a/src/applications/differential/storage/DifferentialRevision.php +++ b/src/applications/differential/storage/DifferentialRevision.php @@ -991,10 +991,6 @@ return new DifferentialTransactionEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new DifferentialTransaction(); } diff --git a/src/applications/diviner/storage/DivinerLiveBook.php b/src/applications/diviner/storage/DivinerLiveBook.php --- a/src/applications/diviner/storage/DivinerLiveBook.php +++ b/src/applications/diviner/storage/DivinerLiveBook.php @@ -143,10 +143,6 @@ return new DivinerLiveBookEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new DivinerLiveBookTransaction(); } diff --git a/src/applications/drydock/storage/DrydockBlueprint.php b/src/applications/drydock/storage/DrydockBlueprint.php --- a/src/applications/drydock/storage/DrydockBlueprint.php +++ b/src/applications/drydock/storage/DrydockBlueprint.php @@ -295,10 +295,6 @@ return new DrydockBlueprintEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new DrydockBlueprintTransaction(); } diff --git a/src/applications/files/storage/PhabricatorFile.php b/src/applications/files/storage/PhabricatorFile.php --- a/src/applications/files/storage/PhabricatorFile.php +++ b/src/applications/files/storage/PhabricatorFile.php @@ -1544,10 +1544,6 @@ return new PhabricatorFileEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorFileTransaction(); } diff --git a/src/applications/fund/storage/FundBacker.php b/src/applications/fund/storage/FundBacker.php --- a/src/applications/fund/storage/FundBacker.php +++ b/src/applications/fund/storage/FundBacker.php @@ -110,10 +110,6 @@ return new FundBackerEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new FundBackerTransaction(); } diff --git a/src/applications/fund/storage/FundInitiative.php b/src/applications/fund/storage/FundInitiative.php --- a/src/applications/fund/storage/FundInitiative.php +++ b/src/applications/fund/storage/FundInitiative.php @@ -160,10 +160,6 @@ return new FundInitiativeEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new FundInitiativeTransaction(); } diff --git a/src/applications/harbormaster/engine/HarbormasterBuildableEngine.php b/src/applications/harbormaster/engine/HarbormasterBuildableEngine.php --- a/src/applications/harbormaster/engine/HarbormasterBuildableEngine.php +++ b/src/applications/harbormaster/engine/HarbormasterBuildableEngine.php @@ -96,9 +96,7 @@ $publishable = $this->getPublishableObject(); $editor = $this->newEditor(); - $editor->applyTransactions( - $publishable->getApplicationTransactionObject(), - $xactions); + $editor->applyTransactions($publishable, $xactions); } public function getAuthorIdentity() { diff --git a/src/applications/harbormaster/storage/HarbormasterBuildable.php b/src/applications/harbormaster/storage/HarbormasterBuildable.php --- a/src/applications/harbormaster/storage/HarbormasterBuildable.php +++ b/src/applications/harbormaster/storage/HarbormasterBuildable.php @@ -283,10 +283,6 @@ return new HarbormasterBuildableTransactionEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new HarbormasterBuildableTransaction(); } diff --git a/src/applications/harbormaster/storage/build/HarbormasterBuild.php b/src/applications/harbormaster/storage/build/HarbormasterBuild.php --- a/src/applications/harbormaster/storage/build/HarbormasterBuild.php +++ b/src/applications/harbormaster/storage/build/HarbormasterBuild.php @@ -393,10 +393,6 @@ return new HarbormasterBuildTransactionEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new HarbormasterBuildTransaction(); } diff --git a/src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php b/src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php --- a/src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php +++ b/src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php @@ -136,10 +136,6 @@ return new HarbormasterBuildPlanEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new HarbormasterBuildPlanTransaction(); } diff --git a/src/applications/harbormaster/storage/configuration/HarbormasterBuildStep.php b/src/applications/harbormaster/storage/configuration/HarbormasterBuildStep.php --- a/src/applications/harbormaster/storage/configuration/HarbormasterBuildStep.php +++ b/src/applications/harbormaster/storage/configuration/HarbormasterBuildStep.php @@ -121,10 +121,6 @@ return new HarbormasterBuildStepEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new HarbormasterBuildStepTransaction(); } diff --git a/src/applications/herald/storage/HeraldRule.php b/src/applications/herald/storage/HeraldRule.php --- a/src/applications/herald/storage/HeraldRule.php +++ b/src/applications/herald/storage/HeraldRule.php @@ -318,10 +318,6 @@ return new HeraldRuleEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new HeraldRuleTransaction(); } diff --git a/src/applications/herald/storage/HeraldWebhook.php b/src/applications/herald/storage/HeraldWebhook.php --- a/src/applications/herald/storage/HeraldWebhook.php +++ b/src/applications/herald/storage/HeraldWebhook.php @@ -200,10 +200,6 @@ return new HeraldWebhookEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new HeraldWebhookTransaction(); } diff --git a/src/applications/legalpad/storage/LegalpadDocument.php b/src/applications/legalpad/storage/LegalpadDocument.php --- a/src/applications/legalpad/storage/LegalpadDocument.php +++ b/src/applications/legalpad/storage/LegalpadDocument.php @@ -209,10 +209,6 @@ return new LegalpadDocumentEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new LegalpadTransaction(); } diff --git a/src/applications/macro/storage/PhabricatorFileImageMacro.php b/src/applications/macro/storage/PhabricatorFileImageMacro.php --- a/src/applications/macro/storage/PhabricatorFileImageMacro.php +++ b/src/applications/macro/storage/PhabricatorFileImageMacro.php @@ -98,10 +98,6 @@ return new PhabricatorMacroEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorMacroTransaction(); } diff --git a/src/applications/maniphest/storage/ManiphestTask.php b/src/applications/maniphest/storage/ManiphestTask.php --- a/src/applications/maniphest/storage/ManiphestTask.php +++ b/src/applications/maniphest/storage/ManiphestTask.php @@ -452,10 +452,6 @@ return new ManiphestTransactionEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new ManiphestTransaction(); } diff --git a/src/applications/metamta/storage/PhabricatorMetaMTAApplicationEmail.php b/src/applications/metamta/storage/PhabricatorMetaMTAApplicationEmail.php --- a/src/applications/metamta/storage/PhabricatorMetaMTAApplicationEmail.php +++ b/src/applications/metamta/storage/PhabricatorMetaMTAApplicationEmail.php @@ -123,10 +123,6 @@ return new PhabricatorMetaMTAApplicationEmailEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorMetaMTAApplicationEmailTransaction(); } diff --git a/src/applications/nuance/storage/NuanceItem.php b/src/applications/nuance/storage/NuanceItem.php --- a/src/applications/nuance/storage/NuanceItem.php +++ b/src/applications/nuance/storage/NuanceItem.php @@ -193,10 +193,6 @@ return new NuanceItemEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new NuanceItemTransaction(); } diff --git a/src/applications/nuance/storage/NuanceQueue.php b/src/applications/nuance/storage/NuanceQueue.php --- a/src/applications/nuance/storage/NuanceQueue.php +++ b/src/applications/nuance/storage/NuanceQueue.php @@ -79,10 +79,6 @@ return new NuanceQueueEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new NuanceQueueTransaction(); } diff --git a/src/applications/nuance/storage/NuanceSource.php b/src/applications/nuance/storage/NuanceSource.php --- a/src/applications/nuance/storage/NuanceSource.php +++ b/src/applications/nuance/storage/NuanceSource.php @@ -99,10 +99,6 @@ return new NuanceSourceEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new NuanceSourceTransaction(); } diff --git a/src/applications/oauthserver/storage/PhabricatorOAuthServerClient.php b/src/applications/oauthserver/storage/PhabricatorOAuthServerClient.php --- a/src/applications/oauthserver/storage/PhabricatorOAuthServerClient.php +++ b/src/applications/oauthserver/storage/PhabricatorOAuthServerClient.php @@ -91,10 +91,6 @@ return new PhabricatorOAuthServerEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorOAuthServerTransaction(); } diff --git a/src/applications/owners/storage/PhabricatorOwnersPackage.php b/src/applications/owners/storage/PhabricatorOwnersPackage.php --- a/src/applications/owners/storage/PhabricatorOwnersPackage.php +++ b/src/applications/owners/storage/PhabricatorOwnersPackage.php @@ -607,10 +607,6 @@ return new PhabricatorOwnersPackageTransactionEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorOwnersPackageTransaction(); } diff --git a/src/applications/packages/storage/PhabricatorPackagesPackage.php b/src/applications/packages/storage/PhabricatorPackagesPackage.php --- a/src/applications/packages/storage/PhabricatorPackagesPackage.php +++ b/src/applications/packages/storage/PhabricatorPackagesPackage.php @@ -189,10 +189,6 @@ return new PhabricatorPackagesPackageEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorPackagesPackageTransaction(); } diff --git a/src/applications/packages/storage/PhabricatorPackagesPublisher.php b/src/applications/packages/storage/PhabricatorPackagesPublisher.php --- a/src/applications/packages/storage/PhabricatorPackagesPublisher.php +++ b/src/applications/packages/storage/PhabricatorPackagesPublisher.php @@ -165,10 +165,6 @@ return new PhabricatorPackagesPublisherEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorPackagesPublisherTransaction(); } diff --git a/src/applications/packages/storage/PhabricatorPackagesVersion.php b/src/applications/packages/storage/PhabricatorPackagesVersion.php --- a/src/applications/packages/storage/PhabricatorPackagesVersion.php +++ b/src/applications/packages/storage/PhabricatorPackagesVersion.php @@ -156,10 +156,6 @@ return new PhabricatorPackagesVersionEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorPackagesVersionTransaction(); } diff --git a/src/applications/passphrase/storage/PassphraseCredential.php b/src/applications/passphrase/storage/PassphraseCredential.php --- a/src/applications/passphrase/storage/PassphraseCredential.php +++ b/src/applications/passphrase/storage/PassphraseCredential.php @@ -117,10 +117,6 @@ return new PassphraseCredentialTransactionEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PassphraseCredentialTransaction(); } diff --git a/src/applications/paste/storage/PhabricatorPaste.php b/src/applications/paste/storage/PhabricatorPaste.php --- a/src/applications/paste/storage/PhabricatorPaste.php +++ b/src/applications/paste/storage/PhabricatorPaste.php @@ -219,10 +219,6 @@ return new PhabricatorPasteEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorPasteTransaction(); } diff --git a/src/applications/people/storage/PhabricatorUser.php b/src/applications/people/storage/PhabricatorUser.php --- a/src/applications/people/storage/PhabricatorUser.php +++ b/src/applications/people/storage/PhabricatorUser.php @@ -1371,10 +1371,6 @@ return new PhabricatorUserTransactionEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorUserTransaction(); } diff --git a/src/applications/phame/storage/PhameBlog.php b/src/applications/phame/storage/PhameBlog.php --- a/src/applications/phame/storage/PhameBlog.php +++ b/src/applications/phame/storage/PhameBlog.php @@ -331,10 +331,6 @@ return new PhameBlogEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhameBlogTransaction(); } diff --git a/src/applications/phame/storage/PhamePost.php b/src/applications/phame/storage/PhamePost.php --- a/src/applications/phame/storage/PhamePost.php +++ b/src/applications/phame/storage/PhamePost.php @@ -279,10 +279,6 @@ return new PhamePostEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhamePostTransaction(); } diff --git a/src/applications/phlux/storage/PhluxVariable.php b/src/applications/phlux/storage/PhluxVariable.php --- a/src/applications/phlux/storage/PhluxVariable.php +++ b/src/applications/phlux/storage/PhluxVariable.php @@ -41,10 +41,6 @@ return new PhluxVariableEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhluxTransaction(); } diff --git a/src/applications/pholio/storage/PholioMock.php b/src/applications/pholio/storage/PholioMock.php --- a/src/applications/pholio/storage/PholioMock.php +++ b/src/applications/pholio/storage/PholioMock.php @@ -221,10 +221,6 @@ return new PholioMockEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PholioTransaction(); } diff --git a/src/applications/phortune/storage/PhortuneAccount.php b/src/applications/phortune/storage/PhortuneAccount.php --- a/src/applications/phortune/storage/PhortuneAccount.php +++ b/src/applications/phortune/storage/PhortuneAccount.php @@ -105,10 +105,6 @@ return new PhortuneAccountEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhortuneAccountTransaction(); } diff --git a/src/applications/phortune/storage/PhortuneCart.php b/src/applications/phortune/storage/PhortuneCart.php --- a/src/applications/phortune/storage/PhortuneCart.php +++ b/src/applications/phortune/storage/PhortuneCart.php @@ -636,10 +636,6 @@ return new PhortuneCartEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhortuneCartTransaction(); } diff --git a/src/applications/phortune/storage/PhortuneMerchant.php b/src/applications/phortune/storage/PhortuneMerchant.php --- a/src/applications/phortune/storage/PhortuneMerchant.php +++ b/src/applications/phortune/storage/PhortuneMerchant.php @@ -78,10 +78,6 @@ return new PhortuneMerchantEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhortuneMerchantTransaction(); } diff --git a/src/applications/phortune/storage/PhortunePaymentProviderConfig.php b/src/applications/phortune/storage/PhortunePaymentProviderConfig.php --- a/src/applications/phortune/storage/PhortunePaymentProviderConfig.php +++ b/src/applications/phortune/storage/PhortunePaymentProviderConfig.php @@ -106,10 +106,6 @@ return new PhortunePaymentProviderConfigEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhortunePaymentProviderConfigTransaction(); } diff --git a/src/applications/phriction/storage/PhrictionDocument.php b/src/applications/phriction/storage/PhrictionDocument.php --- a/src/applications/phriction/storage/PhrictionDocument.php +++ b/src/applications/phriction/storage/PhrictionDocument.php @@ -223,10 +223,6 @@ return new PhrictionTransactionEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhrictionTransaction(); } diff --git a/src/applications/phurl/storage/PhabricatorPhurlURL.php b/src/applications/phurl/storage/PhabricatorPhurlURL.php --- a/src/applications/phurl/storage/PhabricatorPhurlURL.php +++ b/src/applications/phurl/storage/PhabricatorPhurlURL.php @@ -157,10 +157,6 @@ return new PhabricatorPhurlURLEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorPhurlURLTransaction(); } diff --git a/src/applications/ponder/storage/PonderAnswer.php b/src/applications/ponder/storage/PonderAnswer.php --- a/src/applications/ponder/storage/PonderAnswer.php +++ b/src/applications/ponder/storage/PonderAnswer.php @@ -117,10 +117,6 @@ return new PonderAnswerEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PonderAnswerTransaction(); } diff --git a/src/applications/ponder/storage/PonderQuestion.php b/src/applications/ponder/storage/PonderQuestion.php --- a/src/applications/ponder/storage/PonderQuestion.php +++ b/src/applications/ponder/storage/PonderQuestion.php @@ -145,10 +145,6 @@ return new PonderQuestionEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PonderQuestionTransaction(); } diff --git a/src/applications/project/storage/PhabricatorProject.php b/src/applications/project/storage/PhabricatorProject.php --- a/src/applications/project/storage/PhabricatorProject.php +++ b/src/applications/project/storage/PhabricatorProject.php @@ -695,10 +695,6 @@ return new PhabricatorProjectTransactionEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorProjectTransaction(); } diff --git a/src/applications/project/storage/PhabricatorProjectColumn.php b/src/applications/project/storage/PhabricatorProjectColumn.php --- a/src/applications/project/storage/PhabricatorProjectColumn.php +++ b/src/applications/project/storage/PhabricatorProjectColumn.php @@ -234,10 +234,6 @@ return new PhabricatorProjectColumnTransactionEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorProjectColumnTransaction(); } diff --git a/src/applications/releeph/storage/ReleephBranch.php b/src/applications/releeph/storage/ReleephBranch.php --- a/src/applications/releeph/storage/ReleephBranch.php +++ b/src/applications/releeph/storage/ReleephBranch.php @@ -158,10 +158,6 @@ return new ReleephBranchEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new ReleephBranchTransaction(); } diff --git a/src/applications/releeph/storage/ReleephProject.php b/src/applications/releeph/storage/ReleephProject.php --- a/src/applications/releeph/storage/ReleephProject.php +++ b/src/applications/releeph/storage/ReleephProject.php @@ -119,10 +119,6 @@ return new ReleephProductEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new ReleephProductTransaction(); } diff --git a/src/applications/releeph/storage/ReleephRequest.php b/src/applications/releeph/storage/ReleephRequest.php --- a/src/applications/releeph/storage/ReleephRequest.php +++ b/src/applications/releeph/storage/ReleephRequest.php @@ -299,10 +299,6 @@ return new ReleephRequestTransactionalEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new ReleephRequestTransaction(); } diff --git a/src/applications/repository/storage/PhabricatorRepository.php b/src/applications/repository/storage/PhabricatorRepository.php --- a/src/applications/repository/storage/PhabricatorRepository.php +++ b/src/applications/repository/storage/PhabricatorRepository.php @@ -2613,10 +2613,6 @@ return new PhabricatorRepositoryEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorRepositoryTransaction(); } diff --git a/src/applications/repository/storage/PhabricatorRepositoryCommit.php b/src/applications/repository/storage/PhabricatorRepositoryCommit.php --- a/src/applications/repository/storage/PhabricatorRepositoryCommit.php +++ b/src/applications/repository/storage/PhabricatorRepositoryCommit.php @@ -731,10 +731,6 @@ return new PhabricatorAuditEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorAuditTransaction(); } diff --git a/src/applications/repository/storage/PhabricatorRepositoryIdentity.php b/src/applications/repository/storage/PhabricatorRepositoryIdentity.php --- a/src/applications/repository/storage/PhabricatorRepositoryIdentity.php +++ b/src/applications/repository/storage/PhabricatorRepositoryIdentity.php @@ -134,10 +134,6 @@ return new DiffusionRepositoryIdentityEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorRepositoryIdentityTransaction(); } diff --git a/src/applications/repository/storage/PhabricatorRepositoryURI.php b/src/applications/repository/storage/PhabricatorRepositoryURI.php --- a/src/applications/repository/storage/PhabricatorRepositoryURI.php +++ b/src/applications/repository/storage/PhabricatorRepositoryURI.php @@ -605,10 +605,6 @@ return new DiffusionURIEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorRepositoryURITransaction(); } diff --git a/src/applications/search/storage/PhabricatorProfileMenuItemConfiguration.php b/src/applications/search/storage/PhabricatorProfileMenuItemConfiguration.php --- a/src/applications/search/storage/PhabricatorProfileMenuItemConfiguration.php +++ b/src/applications/search/storage/PhabricatorProfileMenuItemConfiguration.php @@ -265,10 +265,6 @@ return new PhabricatorProfileMenuEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorProfileMenuItemConfigurationTransaction(); } diff --git a/src/applications/settings/storage/PhabricatorUserPreferences.php b/src/applications/settings/storage/PhabricatorUserPreferences.php --- a/src/applications/settings/storage/PhabricatorUserPreferences.php +++ b/src/applications/settings/storage/PhabricatorUserPreferences.php @@ -245,10 +245,6 @@ return new PhabricatorUserPreferencesEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorUserPreferencesTransaction(); } diff --git a/src/applications/slowvote/storage/PhabricatorSlowvotePoll.php b/src/applications/slowvote/storage/PhabricatorSlowvotePoll.php --- a/src/applications/slowvote/storage/PhabricatorSlowvotePoll.php +++ b/src/applications/slowvote/storage/PhabricatorSlowvotePoll.php @@ -131,10 +131,6 @@ return new PhabricatorSlowvoteEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorSlowvoteTransaction(); } diff --git a/src/applications/spaces/storage/PhabricatorSpacesNamespace.php b/src/applications/spaces/storage/PhabricatorSpacesNamespace.php --- a/src/applications/spaces/storage/PhabricatorSpacesNamespace.php +++ b/src/applications/spaces/storage/PhabricatorSpacesNamespace.php @@ -91,10 +91,6 @@ return new PhabricatorSpacesNamespaceEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorSpacesNamespaceTransaction(); } diff --git a/src/applications/subscriptions/controller/PhabricatorSubscriptionsEditController.php b/src/applications/subscriptions/controller/PhabricatorSubscriptionsEditController.php --- a/src/applications/subscriptions/controller/PhabricatorSubscriptionsEditController.php +++ b/src/applications/subscriptions/controller/PhabricatorSubscriptionsEditController.php @@ -77,9 +77,7 @@ ->setContinueOnMissingFields(true) ->setContentSourceFromRequest($request); - $editor->applyTransactions( - $object->getApplicationTransactionObject(), - array($xaction)); + $editor->applyTransactions($object, array($xaction)); } else { // TODO: Eventually, get rid of this once everything implements diff --git a/src/applications/subscriptions/controller/PhabricatorSubscriptionsMuteController.php b/src/applications/subscriptions/controller/PhabricatorSubscriptionsMuteController.php --- a/src/applications/subscriptions/controller/PhabricatorSubscriptionsMuteController.php +++ b/src/applications/subscriptions/controller/PhabricatorSubscriptionsMuteController.php @@ -55,9 +55,7 @@ ->setContinueOnMissingFields(true) ->setContentSourceFromRequest($request); - $editor->applyTransactions( - $object->getApplicationTransactionObject(), - array($xaction)); + $editor->applyTransactions($object, array($xaction)); return id(new AphrontReloadResponse())->setURI($object_uri); } diff --git a/src/applications/tokens/editor/PhabricatorTokenGivenEditor.php b/src/applications/tokens/editor/PhabricatorTokenGivenEditor.php --- a/src/applications/tokens/editor/PhabricatorTokenGivenEditor.php +++ b/src/applications/tokens/editor/PhabricatorTokenGivenEditor.php @@ -166,9 +166,7 @@ ->setContinueOnNoEffect(true) ->setContinueOnMissingFields(true); - $editor->applyTransactions( - $object->getApplicationTransactionObject(), - $xactions); + $editor->applyTransactions($object, $xactions); } } diff --git a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php --- a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php +++ b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php @@ -3766,7 +3766,6 @@ $editor = $node->getApplicationTransactionEditor(); $template = $node->getApplicationTransactionTemplate(); - $target = $node->getApplicationTransactionObject(); if (isset($add[$node->getPHID()])) { $edge_edit_type = '+'; @@ -3792,7 +3791,7 @@ ->setActingAsPHID($this->getActingAsPHID()) ->setContentSource($this->getContentSource()); - $editor->applyTransactions($target, array($template)); + $editor->applyTransactions($node, array($template)); } } diff --git a/src/applications/transactions/interface/PhabricatorApplicationTransactionInterface.php b/src/applications/transactions/interface/PhabricatorApplicationTransactionInterface.php --- a/src/applications/transactions/interface/PhabricatorApplicationTransactionInterface.php +++ b/src/applications/transactions/interface/PhabricatorApplicationTransactionInterface.php @@ -17,17 +17,6 @@ public function getApplicationTransactionEditor(); - /** - * Return the object to apply transactions to. Normally this is the current - * object (that is, `$this`), but in some cases transactions may apply to - * a different object: for example, @{class:DifferentialDiff} applies - * transactions to the associated @{class:DifferentialRevision}. - * - * @return PhabricatorLiskDAO Object to apply transactions to. - */ - public function getApplicationTransactionObject(); - - /** * Return a template transaction for this object. * @@ -47,10 +36,6 @@ return new <<>>Editor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new <<>>Transaction(); } diff --git a/src/applications/transactions/replyhandler/PhabricatorApplicationTransactionReplyHandler.php b/src/applications/transactions/replyhandler/PhabricatorApplicationTransactionReplyHandler.php --- a/src/applications/transactions/replyhandler/PhabricatorApplicationTransactionReplyHandler.php +++ b/src/applications/transactions/replyhandler/PhabricatorApplicationTransactionReplyHandler.php @@ -107,11 +107,9 @@ ->attachComment($comment); } - $target = $object->getApplicationTransactionObject(); - $this->newEditor($mail) ->setContinueOnNoEffect(true) - ->applyTransactions($target, $xactions); + ->applyTransactions($object, $xactions); } private function processMailCommands( diff --git a/src/applications/transactions/storage/PhabricatorEditEngineConfiguration.php b/src/applications/transactions/storage/PhabricatorEditEngineConfiguration.php --- a/src/applications/transactions/storage/PhabricatorEditEngineConfiguration.php +++ b/src/applications/transactions/storage/PhabricatorEditEngineConfiguration.php @@ -339,10 +339,6 @@ return new PhabricatorEditEngineConfigurationEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorEditEngineConfigurationTransaction(); } diff --git a/src/infrastructure/daemon/workers/storage/PhabricatorWorkerBulkJob.php b/src/infrastructure/daemon/workers/storage/PhabricatorWorkerBulkJob.php --- a/src/infrastructure/daemon/workers/storage/PhabricatorWorkerBulkJob.php +++ b/src/infrastructure/daemon/workers/storage/PhabricatorWorkerBulkJob.php @@ -233,10 +233,6 @@ return new PhabricatorWorkerBulkJobEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorWorkerBulkJobTransaction(); }