Page MenuHomePhabricator

Move admin promotions to modular transactions
ClosedPublic

Authored by amckinley on Dec 14 2018, 11:26 PM.
Tags
None
Referenced Files
F14058059: D19891.diff
Sun, Nov 17, 9:14 AM
F14012865: D19891.diff
Fri, Nov 1, 8:32 PM
F14006377: D19891.diff
Mon, Oct 28, 7:54 AM
F13998590: D19891.diff
Thu, Oct 24, 10:05 AM
F13974644: D19891.id47494.diff
Oct 18 2024, 6:34 AM
F13967795: D19891.id47513.diff
Oct 16 2024, 4:01 PM
Unknown Object (File)
Sep 25 2024, 9:57 PM
Unknown Object (File)
Sep 14 2024, 3:03 AM
Subscribers

Details

Summary

Continue clean up of super-old code. I am pretty proud of "defrocked", but would also consider "dethroned", "ousted", "unseated", "unmade", or "disenfranchised". I feel like there's a word for being kicked out of Hogwarts and having your wizarding powers revoked, but it is not leaping to mind.

Test Plan

Promoted/demoted users to/from admin, attempted to demote myself and observed preserved witty text, checked user timelines, checked feed, checked DB for sanity, including user_logs. I didn't test exposing this via Conduit to attempt promoting a user without having admin access.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I feel like there's a word for being kicked out of Hogwarts and having your wizarding powers revoked, but it is not leaping to mind.

Maybe it's "muggleize".

Or "moogled" (from Secret of Mana?)

Change looks good.

This revision is now accepted and ready to land.Dec 14 2018, 11:37 PM
This revision was automatically updated to reflect the committed changes.