Page MenuHomePhabricator

Move admin promotions to modular transactions
ClosedPublic

Authored by amckinley on Dec 14 2018, 11:26 PM.

Details

Summary

Continue clean up of super-old code. I am pretty proud of "defrocked", but would also consider "dethroned", "ousted", "unseated", "unmade", or "disenfranchised". I feel like there's a word for being kicked out of Hogwarts and having your wizarding powers revoked, but it is not leaping to mind.

Test Plan

Promoted/demoted users to/from admin, attempted to demote myself and observed preserved witty text, checked user timelines, checked feed, checked DB for sanity, including user_logs. I didn't test exposing this via Conduit to attempt promoting a user without having admin access.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

amckinley created this revision.Dec 14 2018, 11:26 PM
amckinley requested review of this revision.Dec 14 2018, 11:28 PM
epriestley accepted this revision.Dec 14 2018, 11:37 PM

I feel like there's a word for being kicked out of Hogwarts and having your wizarding powers revoked, but it is not leaping to mind.

Maybe it's "muggleize".

Or "moogled" (from Secret of Mana?)

Change looks good.

This revision is now accepted and ready to land.Dec 14 2018, 11:37 PM
This revision was automatically updated to reflect the committed changes.