Paths

Table of Contentst

Differential D19878

Remove all application callers to "putInSet()"
ClosedPublic
Actions

Authored by epriestley on Dec 13 2018, 12:13 AM.

Tags

None

Subscribers

Details

Reviewers

Maniphest Tasks

T13218: Remove LiskDAO->loadOneRelative()

Commits

rP02933acbd5ae: Remove all application callers to "putInSet()"

Summary

Ref T13218. This is the last public-facing API call for loadRelatives/loadOneRelative. This just "primed" objects to make the other calls work and had no direct effects.

Test Plan

Ran bin/fact analyze.
Used bin/storage upgrade -f --apply to apply 20181031.board.01.queryreset.php, which uses LiskMigrationIterator.
Browsed user list.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Dec 13 2018, 12:13 AM

Herald added a subscriber: yelirekim. · View Herald TranscriptDec 13 2018, 12:13 AM

Harbormaster completed remote builds in B21320: Diff 47469.Dec 13 2018, 12:15 AM

epriestley requested review of this revision.Dec 13 2018, 12:15 AM

amckinley accepted this revision.Dec 13 2018, 12:27 AM

This revision is now accepted and ready to land.Dec 13 2018, 12:27 AM

Closed by commit rP02933acbd5ae: Remove all application callers to "putInSet()" (authored by epriestley). · Explain WhyDec 13 2018, 12:41 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

fact/

extract/

PhabricatorFactUpdateIterator.php

7 lines

people/

query/

PhabricatorPeopleQuery.php

9 lines

infrastructure/

storage/

lisk/

LiskMigrationIterator.php

8 lines

Diff 47473

src/applications/fact/extract/PhabricatorFactUpdateIterator.php

Loading...

src/applications/people/query/PhabricatorPeopleQuery.php

Loading...

src/infrastructure/storage/lisk/LiskMigrationIterator.php

Loading...