Paths

Table of Contentst

Differential D19832

Recover when cookies are disabled in Firefox and accessing localStorage throws
ClosedPublic
Actions

Authored by epriestley on Nov 24 2018, 2:25 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13216: 2018 Week 45-47 Bonus Content

Commits

rP2e8a5e843f95: Recover when cookies are disabled in Firefox and accessing localStorage throws

Summary

Ref T13216. See PHI985. If you disable cookies in Firefox, accessing window.localStorage throws an exception. Currently, this pretty much kills all scripts on the page.

Instead, catch and ignore this, as though window.localStorage was not defined.

Test Plan

Set Firefox to "no cookies".
Loaded any page while logged out.
Before: JS fatal early in the stack.
After: page loads and JS works.

Diff Detail

Repository

rP Phabricator

Branch

firefox1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21206
Build 28839: Run Core Tests
Build 28838: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 24 2018, 2:25 PM

Harbormaster completed remote builds in B21206: Diff 47357.Nov 24 2018, 2:27 PM

epriestley requested review of this revision.Nov 24 2018, 2:27 PM

amckinley accepted this revision.Nov 26 2018, 4:48 PM

This revision is now accepted and ready to land.Nov 26 2018, 4:48 PM

Closed by commit rP2e8a5e843f95: Recover when cookies are disabled in Firefox and accessing localStorage throws (authored by epriestley). · Explain WhyNov 27 2018, 12:30 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

webroot/

rsrc/

externals/

javelin/

core/

init.js

9 lines

Diff 47357

View Options

resources/celerity/map.php