diff --git a/src/applications/repository/editor/PhabricatorRepositoryEditor.php b/src/applications/repository/editor/PhabricatorRepositoryEditor.php --- a/src/applications/repository/editor/PhabricatorRepositoryEditor.php +++ b/src/applications/repository/editor/PhabricatorRepositoryEditor.php @@ -22,7 +22,6 @@ $types[] = PhabricatorRepositoryTransaction::TYPE_DEFAULT_BRANCH; $types[] = PhabricatorRepositoryTransaction::TYPE_TRACK_ONLY; $types[] = PhabricatorRepositoryTransaction::TYPE_AUTOCLOSE_ONLY; - $types[] = PhabricatorRepositoryTransaction::TYPE_UUID; $types[] = PhabricatorRepositoryTransaction::TYPE_SVN_SUBPATH; $types[] = PhabricatorRepositoryTransaction::TYPE_NOTIFY; $types[] = PhabricatorRepositoryTransaction::TYPE_AUTOCLOSE; @@ -65,8 +64,6 @@ return array_keys($object->getDetail('branch-filter', array())); case PhabricatorRepositoryTransaction::TYPE_AUTOCLOSE_ONLY: return array_keys($object->getDetail('close-commits-filter', array())); - case PhabricatorRepositoryTransaction::TYPE_UUID: - return $object->getUUID(); case PhabricatorRepositoryTransaction::TYPE_SVN_SUBPATH: return $object->getDetail('svn-subpath'); case PhabricatorRepositoryTransaction::TYPE_NOTIFY: @@ -108,7 +105,6 @@ case PhabricatorRepositoryTransaction::TYPE_DEFAULT_BRANCH: case PhabricatorRepositoryTransaction::TYPE_TRACK_ONLY: case PhabricatorRepositoryTransaction::TYPE_AUTOCLOSE_ONLY: - case PhabricatorRepositoryTransaction::TYPE_UUID: case PhabricatorRepositoryTransaction::TYPE_SVN_SUBPATH: case PhabricatorRepositoryTransaction::TYPE_VCS: case PhabricatorRepositoryTransaction::TYPE_PUSH_POLICY: @@ -171,9 +167,6 @@ 'close-commits-filter', array_fill_keys($xaction->getNewValue(), true)); break; - case PhabricatorRepositoryTransaction::TYPE_UUID: - $object->setUUID($xaction->getNewValue()); - break; case PhabricatorRepositoryTransaction::TYPE_SVN_SUBPATH: $object->setDetail('svn-subpath', $xaction->getNewValue()); break; diff --git a/src/applications/repository/storage/PhabricatorRepositoryTransaction.php b/src/applications/repository/storage/PhabricatorRepositoryTransaction.php --- a/src/applications/repository/storage/PhabricatorRepositoryTransaction.php +++ b/src/applications/repository/storage/PhabricatorRepositoryTransaction.php @@ -25,20 +25,6 @@ const TYPE_AUTOMATION_BLUEPRINTS = 'repo:automation-blueprints'; const TYPE_CALLSIGN = 'repo:callsign'; - // TODO: Clean up these legacy transaction types. - const TYPE_SSH_LOGIN = 'repo:ssh-login'; - const TYPE_SSH_KEY = 'repo:ssh-key'; - const TYPE_SSH_KEYFILE = 'repo:ssh-keyfile'; - const TYPE_HTTP_LOGIN = 'repo:http-login'; - const TYPE_HTTP_PASS = 'repo:http-pass'; - const TYPE_CREDENTIAL = 'repo:credential'; - const TYPE_PROTOCOL_HTTP = 'repo:serve-http'; - const TYPE_PROTOCOL_SSH = 'repo:serve-ssh'; - const TYPE_HOSTING = 'repo:hosting'; - const TYPE_LOCAL_PATH = 'repo:local-path'; - const TYPE_REMOTE_URI = 'repo:remote-uri'; - const TYPE_UUID = 'repo:uuid'; - public function getApplicationName() { return 'repository'; } @@ -86,15 +72,6 @@ $new = $this->getNewValue(); switch ($this->getTransactionType()) { - case self::TYPE_REMOTE_URI: - case self::TYPE_SSH_LOGIN: - case self::TYPE_SSH_KEY: - case self::TYPE_SSH_KEYFILE: - case self::TYPE_HTTP_LOGIN: - case self::TYPE_HTTP_PASS: - // Hide null vs empty string changes. - return (!strlen($old) && !strlen($new)); - case self::TYPE_LOCAL_PATH: case self::TYPE_NAME: // Hide these on create, they aren't interesting and we have an // explicit "create" transaction. @@ -233,25 +210,6 @@ implode(', ', $new)); } break; - case self::TYPE_UUID: - if (!strlen($new)) { - return pht( - '%s removed "%s" as the repository UUID.', - $this->renderHandleLink($author_phid), - $old); - } else if (!strlen($old)) { - return pht( - '%s set the repository UUID to "%s".', - $this->renderHandleLink($author_phid), - $new); - } else { - return pht( - '%s changed the repository UUID from "%s" to "%s".', - $this->renderHandleLink($author_phid), - $old, - $new); - } - break; case self::TYPE_SVN_SUBPATH: if (!strlen($new)) { return pht( @@ -293,74 +251,6 @@ $this->renderHandleLink($author_phid)); } break; - case self::TYPE_REMOTE_URI: - if (!strlen($old)) { - return pht( - '%s set the remote URI for this repository to "%s".', - $this->renderHandleLink($author_phid), - $new); - } else if (!strlen($new)) { - return pht( - '%s removed the remote URI for this repository.', - $this->renderHandleLink($author_phid)); - } else { - return pht( - '%s changed the remote URI for this repository from "%s" to "%s".', - $this->renderHandleLink($author_phid), - $old, - $new); - } - break; - case self::TYPE_SSH_LOGIN: - return pht( - '%s updated the SSH login for this repository.', - $this->renderHandleLink($author_phid)); - case self::TYPE_SSH_KEY: - return pht( - '%s updated the SSH key for this repository.', - $this->renderHandleLink($author_phid)); - case self::TYPE_SSH_KEYFILE: - return pht( - '%s updated the SSH keyfile for this repository.', - $this->renderHandleLink($author_phid)); - case self::TYPE_HTTP_LOGIN: - return pht( - '%s updated the HTTP login for this repository.', - $this->renderHandleLink($author_phid)); - case self::TYPE_HTTP_PASS: - return pht( - '%s updated the HTTP password for this repository.', - $this->renderHandleLink($author_phid)); - case self::TYPE_LOCAL_PATH: - return pht( - '%s changed the local path from "%s" to "%s".', - $this->renderHandleLink($author_phid), - $old, - $new); - case self::TYPE_HOSTING: - if ($new) { - return pht( - '%s changed this repository to be hosted on Phabricator.', - $this->renderHandleLink($author_phid)); - } else { - return pht( - '%s changed this repository to track a remote elsewhere.', - $this->renderHandleLink($author_phid)); - } - case self::TYPE_PROTOCOL_HTTP: - return pht( - '%s changed the availability of this repository over HTTP from '. - '"%s" to "%s".', - $this->renderHandleLink($author_phid), - $old, - $new); - case self::TYPE_PROTOCOL_SSH: - return pht( - '%s changed the availability of this repository over SSH from '. - '"%s" to "%s".', - $this->renderHandleLink($author_phid), - $old, - $new); case self::TYPE_PUSH_POLICY: return pht( '%s changed the push policy of this repository from "%s" to "%s".',