Paths

Table of Contentst

Differential D19809

Improve text overflow behavior for hovercards with (for example) long package names
ClosedPublic
Actions

Authored by epriestley on Nov 15 2018, 12:18 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13216: 2018 Week 45-47 Bonus Content

Commits

rPec452e548a0d: Improve text overflow behavior for hovercards with (for example) long package…

Summary

See PHI977. Ref T13216. Some text, like long package names, may overflow hovercards. Add overflow CSS behaviors to remedy this.

Test Plan

Before:

Screen Shot 2018-11-15 at 4.14.18 AM.png (664×1 px, 70 KB)

After:

Screen Shot 2018-11-15 at 4.15.34 AM.png (630×967 px, 62 KB)

(You can use /search/hovercard/ to render hovercards in a handy standalone way.)

Diff Detail

Repository

rP Phabricator

Branch

hovercard1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21160
Build 28770: Run Core Tests
Build 28769: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 15 2018, 12:18 PM

Harbormaster completed remote builds in B21160: Diff 47311.Nov 15 2018, 12:20 PM

epriestley requested review of this revision.Nov 15 2018, 12:20 PM

amckinley accepted this revision.Nov 16 2018, 12:04 AM

This revision is now accepted and ready to land.Nov 16 2018, 12:04 AM

Closed by commit rPec452e548a0d: Improve text overflow behavior for hovercards with (for example) long package… (authored by epriestley). · Explain WhyNov 16 2018, 4:43 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

webroot/

rsrc/

css/

phui/

phui-hovercard.css

2 lines

Diff 47311

View Options

resources/celerity/map.php