Page MenuHomePhabricator

Add a `bin/herald test ...` for doing test runs via the CLI
ClosedPublic

Authored by epriestley on Wed, Nov 14, 11:29 PM.

Details

Summary

Ref T13216. See D19666. It's currently tricky to profile Herald test runs since you have to submit a form and repeating them is a bit of a mess. Provide a simple CLI wrapper so we can use --xprofile. This is also maybe nice-to-have if we're ever debugging anything here.

Test Plan

Ran bin/herald test --object ... --type ... and got a sensible looking transcript in the UI.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Wed, Nov 14, 11:29 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Wed, Nov 14, 11:29 PM
Harbormaster failed remote builds in B21148: Diff 47299!
epriestley requested review of this revision.Wed, Nov 14, 11:30 PM

Stacked on qsprintf(),.

amckinley accepted this revision.Thu, Nov 15, 10:20 PM
amckinley added inline comments.
src/applications/herald/management/HeraldTestManagementWorkflow.php
41

Maybe we want to take a PHID as an argument in addition to an object name?

115

It might make sense to test a disabled Herald rule, since the rule might be disabled for bugginess but someone wants to test it from here before reenabling it.

This revision is now accepted and ready to land.Thu, Nov 15, 10:20 PM
epriestley marked 2 inline comments as done.Thu, Nov 15, 11:21 PM
epriestley added inline comments.
src/applications/herald/management/HeraldTestManagementWorkflow.php
41

withNames() is roughly withMonogramsOrPHIDs(...) and will load objects by PHID if PHIDs are passed in.

115

We could theoretically offer single-rule test runs but it would be slightly tricky because of the "Another Herald Rule: ..." condition, which can mean that individual rules don't truly run in isolation.

Reasonable-ish workarounds today are to remove the actions or add an impossible condition at the end of the rule you want to test.

This revision was automatically updated to reflect the committed changes.