Page MenuHomePhabricator

Support %P (Password or Secret) in qsprintf()
ClosedPublic

Authored by epriestley on Nov 7 2018, 12:34 AM.
Tags
None
Referenced Files
F12814596: D19782.diff
Thu, Mar 28, 2:09 AM
Unknown Object (File)
Tue, Mar 19, 3:48 PM
Unknown Object (File)
Feb 16 2024, 10:24 PM
Unknown Object (File)
Feb 3 2024, 7:47 PM
Unknown Object (File)
Jan 29 2024, 5:00 PM
Unknown Object (File)
Dec 25 2023, 6:14 PM
Unknown Object (File)
Dec 23 2023, 8:23 PM
Unknown Object (File)
Dec 22 2023, 12:39 AM
Subscribers
None

Details

Summary

Depends on D19781. Fixes T6960. Ref T13217. Ref T13216. Occasionally, we issue queries which contain passwords or secrets. Supporting "%P" (similar to the csprintf() "%P") allows us to mask these in logs and output while still generating the correct values when we actually execute a query.

Test Plan
$ cat test.php 
<?php

require_once 'scripts/init/init-script.php';

$conn = id(new PhabricatorUser())->establishConnection('r');

$query = qsprintf(
  $conn,
  'SELECT %P',
  new PhutilOpaqueEnvelope('hunter2'));

echo $query."\n";
var_dump(queryfx_one($conn, '%Q', $query));
$ php -f test.php 
SELECT ********
array(1) {
  ["hunter2"]=>
  string(7) "hunter2"
}

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable