Page MenuHomePhabricator

Fix comment box borders in timelines after Phriction commenting
ClosedPublic

Authored by epriestley on Sep 18 2018, 2:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 20, 10:26 PM
Unknown Object (File)
Fri, Mar 15, 10:14 AM
Unknown Object (File)
Dec 26 2023, 6:45 AM
Unknown Object (File)
Dec 24 2023, 4:45 PM
Unknown Object (File)
Dec 21 2023, 1:52 PM
Unknown Object (File)
Nov 30 2023, 4:23 AM
Unknown Object (File)
Nov 17 2023, 6:49 AM
Unknown Object (File)
Nov 16 2023, 4:21 PM
Subscribers
None

Details

Summary

Ref T13202. In D19660, I added comments to Phriction and tweaked some CSS.

One of these tweaks was getting rid of an extra border which was rendering under the comment area. However, I took off too much and ended up removing borders from other applications.

I think we don't actually need this setNoBorder() stuff after all -- a later change was sufficient to stop the actual border I was trying to get rid of from rendering. So this mostly just reverts part of D19660.

This rendering still isn't perfect, but I'm fine leaving that for another day for now.

Test Plan
  • Viewed comment areas in Phriction. Saw correct number of borders (1).
  • Viewed comment areas in Maniphest. Saw correct number of borders (1).
  • Grepped for extraneous removed classs, no hits.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable