Page MenuHomePhabricator

[Wilds] Sort of make "arc help" work again
ClosedPublic

Authored by epriestley on Sep 14 2018, 8:00 PM.
Tags
None
Referenced Files
F14074618: D19679.diff
Thu, Nov 21, 7:55 AM
Unknown Object (File)
Sat, Nov 16, 9:43 PM
Unknown Object (File)
Fri, Nov 1, 11:10 PM
Unknown Object (File)
Tue, Oct 29, 8:42 AM
Unknown Object (File)
Oct 16 2024, 7:30 AM
Unknown Object (File)
Oct 16 2024, 12:49 AM
Unknown Object (File)
Oct 10 2024, 11:07 PM
Unknown Object (File)
Oct 9 2024, 10:08 AM
Subscribers
None

Details

Summary

Ref T13098. This makes "arc help" kind-of sort-of work again.

Previously, "arc help" was completely custom and hard-coded. Now it just proxies the generic libphutil "help" workflow. The two flows are substantially similar, although old arc help was a little more brief than the new version is. The old arc help --full was more similar to the default:

CommandOld BehaviorNew Behavior
arcTells you to run arc help.Plan: make this a bit richer and give a quick summary of workflows.
arc helpGives you a summary of workflows.Gives you a detailed list of workflows.
arc help --fullGives you a detailed list of workflows.No such flag.
arc --helpSame as arc help.Same as arc. Plan: same as arc help.
arc help <workflow>Full workflow help.Full workflow help.
arc <workflow> --helpAs above.As above.

Overall this is largely the same and lets us delete a bunch of code.

Test Plan

Ran arc, arc help, arc --help, arc --help diff, arc diff --help, arc help diff, arc help help.

These commands largely do something sensible now, with caveats per above.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 20832
Build 28337: Run Core Tests

Event Timeline

epriestley created this revision.
This revision is now accepted and ready to land.Sep 19 2018, 6:13 PM
This revision was automatically updated to reflect the committed changes.