[Wilds] Make "arc liberate" run in the untamed wilds
ClosedPublic
Actions

Authored by epriestley on Sep 14 2018, 7:23 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13098: Plans: Arcanist toolsets and extensions

Commits

rARC8e51f89c794b: [Wilds] Make "arc liberate" run in the untamed wilds

Summary

Depends on D19677. Ref T13098. This gets enough of the new workflow/toolset stuff running to run arc liberate (without arguments) so that the new arc can bootstrap itself to continue development.

This change also moves some workflows which will be shared across toolsets (shell completion, versions, help, aliases) out of being arc-specific, to varying degrees of success. These workflows will need to be revisited and cleaned up so they work properly. They mostly fatal when run right now.

The Conduit flags have moved to the new arc parent workflow, but they'll likely move to some kind of support object so my-company-thing megadiff can accept Conduit flags. This is a more involved change, however.

Test Plan

Ran arc liberate, got the Wilds arc to rebuild its own map. Everything else crashes!

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley requested review of this revision.Sep 14 2018, 7:23 PM

epriestley created this revision.

Harbormaster failed remote builds in B20831: Diff 47021!Sep 14 2018, 7:23 PM

Just out of curiosity, why do most of these changes show up as "Context not available"?

This revision is now accepted and ready to land.Sep 19 2018, 5:31 PM

I'm copy-pasting these diffs from the command line with git show | pbcopy, since arc diff doesn't run on any of these branches yet. The git show diff is missing context, versus the git diff -U9999 ... diff that arc generates internally.

I could git diff HEAD^ -U99999 | pbcopy or something to get context, I suppose.

Technically, I could probably also have two copies of arcanist/ and run one on the other (this is supported, at least begrudgingly, to let arc unit --target ... work in arcanist/) but the overall quality of these revisions is so low (in the sense that this code mostly doesn't actually run yet, largely can't be tested, etc) that I figure you aren't missing much.