- Maniphest Tasks
- T13197: 2018 Week 37 Bonus Content
- rP09703938fb44: Migrate old commit saved queries to new audit status constants
Saved some queries on master with numeric constants, ran the migration, saw string constants in the database and equivalent behavior in the UI.
I sanity-checked this against the code and it's correct, but isn't there an easy way to pull this array out of PhabricatorAuditCommitStatusConstants?
So "statuses": 1 as a constraint doesn't work? Or just malformed because diffusion.commit.search and audit.query are both expecting statuses to be list<string>, and this is just very defensive programming?
I'm hard-coding the list in this migration (and two later migrations) so that I can remove the constants from PhabricatorAuditCommitStatusConstants without retaining any confusion/ambiguity going forward.
Yeah, this is mostly just defensive -- "statuses": 1 should be impossible. It also probably doesn't work.