Page MenuHomePhabricator
Differential D19615

Allow unit test results to specify that their details are formatted with remarkup when reporting to "harbormaster.sendmessage"
ClosedPublic
Actions

Authored by epriestley on Aug 28 2018, 8:24 PM.
Tags
None
Referenced Files
F14091646: D19615.diff
Mon, Nov 25, 1:16 AM
F14089065: D19615.diff
Sun, Nov 24, 7:48 AM
Unknown Object (File)
Oct 17 2024, 12:49 PM
Unknown Object (File)
Oct 15 2024, 5:45 AM
Unknown Object (File)
Oct 9 2024, 10:00 AM
Unknown Object (File)
Oct 9 2024, 10:00 AM
Unknown Object (File)
Oct 9 2024, 10:00 AM
Unknown Object (File)
Oct 7 2024, 9:25 PM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
amckinley
Maniphest Tasks
T9951: Store/display more information for Unit tests
T13088: Plans: Harbormaster UI usability and interconnectedness
T13189: Plans: 2018 Week 35 Bonus Content
Commits
rP614f9ba1fba6: Allow unit test results to specify that their details are formatted with…
Summary

Ref T13189. See PHI710. Ref T13088. Fixes T9951. Allow callers to harbormaster.sendmessage to specify that the test details are remarkup so they can use rich formatting and include links, files, etc.

Test Plan

Screen Shot 2018-08-28 at 1.20.56 PM.png (333×623 px, 53 KB)

Diff Detail

Repository
rP Phabricator
Branch
harbor1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20696
Build 28130: Run Core Tests
Build 28129: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 28 2018, 8:24 PM
Owners added a subscriber: Restricted Owners Package.Aug 28 2018, 8:24 PM
Harbormaster completed remote builds in B20696: Diff 46891.Aug 28 2018, 8:25 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 28 2018, 8:25 PM
epriestley requested review of this revision.
Closed by commit rP614f9ba1fba6: Allow unit test results to specify that their details are formatted with… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T9951: Store/display more information for Unit tests.Aug 28 2018, 8:30 PM

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
applications/
differential/
controller/
2 lines
harbormaster/
controller/
3 lines
1 line
18 lines
storage/
build/
75 lines
view/
35 lines
1 line
webroot/
rsrc/
css/
application/
harbormaster/
7 lines

Diff 46891

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterBuildableViewController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterUnitMessageListController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterUnitMessageViewController.php

Loading...
View Options

src/applications/harbormaster/storage/build/HarbormasterBuildUnitMessage.php

Loading...
View Options

src/applications/harbormaster/view/HarbormasterUnitPropertyView.php

Loading...
View Options

src/applications/harbormaster/view/HarbormasterUnitSummaryView.php

Loading...
View Options

webroot/rsrc/css/application/harbormaster/harbormaster.css

Loading...
Phabricator · Built by Phacility