Page MenuHomePhabricator
Differential D19612

Remove another old remarkup engine callsite in Config
ClosedPublic
Actions

Authored by epriestley on Aug 27 2018, 5:53 PM.
Tags
None
Referenced Files
F18986591: D19612.diff
Mon, Nov 17, 3:21 PM
F18954938: D19612.id46886.diff
Wed, Nov 12, 8:18 PM
F18853877: D19612.id.diff
Fri, Oct 31, 8:13 PM
F18847588: D19612.diff
Thu, Oct 30, 1:19 AM
F18819961: D19612.diff
Oct 22 2025, 11:28 AM
F18685138: D19612.id.diff
Sep 26 2025, 10:39 AM
F18635577: D19612.id46885.diff
Sep 17 2025, 2:00 AM
F18568185: D19612.id46886.diff
Sep 9 2025, 11:55 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13189: Plans: 2018 Week 35 Bonus Content
Commits
rPee823982a46b: Remove another old remarkup engine callsite in Config
Summary

Ref T13189. Summaries do not appear to be meaningfully rendered with Remarkup so just drop the engine. See D19610 for the previous change in this vein.

Test Plan

Viewed config list with option summaries.

Diff Detail

Repository
rP Phabricator
Branch
config2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20690
Build 28121: Run Core Tests
Build 28120: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 27 2018, 5:53 PM
Harbormaster completed remote builds in B20690: Diff 46885.Aug 27 2018, 5:54 PM
epriestley requested review of this revision.Aug 27 2018, 5:54 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 27 2018, 6:10 PM
Closed by commit rPee823982a46b: Remove another old remarkup engine callsite in Config (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
config/
controller/
9 lines

Diff 46885

View Options

src/applications/config/controller/PhabricatorConfigGroupController.php

Loading...
Phabricator · Built by Phacility