Differential D19609

When there are no setup issues, don't show a weird empty box
ClosedPublic
Actions

Authored by epriestley on Aug 27 2018, 4:28 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13189: Plans: 2018 Week 35 Bonus Content

Commits

rP0295a0022917: When there are no setup issues, don't show a weird empty box

Summary

Ref T13189. When there are no setup issues, we currently double-render a weird setup issues box underneath the notice. Get rid of it.

Test Plan

Viewed page with and without setup issues, saw less awkward UI.

Diff Detail

Repository

rP Phabricator

Branch

issues1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20684
Build 28112: Run Core Tests
Build 28111: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 27 2018, 4:28 PM

Harbormaster completed remote builds in B20684: Diff 46879.Aug 27 2018, 4:30 PM

epriestley requested review of this revision.Aug 27 2018, 4:30 PM

epriestley added a child revision: D19610: Make some remarkup handling in Config cleaner, fixing {{other.option} links.Aug 27 2018, 4:51 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 27 2018, 4:53 PM

Closed by commit rP0295a0022917: When there are no setup issues, don't show a weird empty box (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

controller/

PhabricatorConfigIssueListController.php

34 lines

Diff 46879

View Options

src/applications/config/controller/PhabricatorConfigIssueListController.php

When there are no setup issues, don't show a weird empty boxClosedPublicActions