Differential D19501

Fix two minor breadcrumb issues in Config
ClosedPublic
Actions

Authored by epriestley on Jun 22 2018, 11:59 AM.

Tags

None

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13159: The "Config" application renders an extra "Config" crumb

Commits

rPb1f4a974fe03: Fix two minor breadcrumb issues in Config

Summary

Fixes T13159. Two issues here:

When viewing a particular config setting, there's an extra "Config" crumb.
On the page for a config group, the link to the parent group has an extra "/config/" in it.

Test Plan

Viewed a page for a particular setting, no longer saw an extra "Config" crumb.
Viewed a page for a setting group, clicked parent crumb, got taken to a real page.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jun 22 2018, 11:59 AM

Harbormaster completed remote builds in B20438: Diff 46632.Jun 22 2018, 12:00 PM

epriestley requested review of this revision.Jun 22 2018, 12:00 PM

amckinley accepted this revision.Jun 22 2018, 11:13 PM

This revision is now accepted and ready to land.Jun 22 2018, 11:13 PM

Closed by commit rPb1f4a974fe03: Fix two minor breadcrumb issues in Config (authored by epriestley). · Explain WhyJun 23 2018, 12:38 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

controller/

PhabricatorConfigEditController.php

1 line

PhabricatorConfigGroupController.php

2 lines

Diff 46638

src/applications/config/controller/PhabricatorConfigEditController.php

Loading...

src/applications/config/controller/PhabricatorConfigGroupController.php

Loading...