Page MenuHomePhabricator

Support logged-out access to more Harbormaster controllers
ClosedPublic

Authored by epriestley on Jun 1 2018, 8:54 PM.
Tags
None
Referenced Files
F19154149: D19459.diff
Thu, Dec 11, 1:36 PM
F19022169: D19459.id46546.diff
Sun, Nov 23, 8:23 PM
F19020182: D19459.diff
Sun, Nov 23, 5:09 PM
F18762704: D19459.diff
Oct 6 2025, 8:16 PM
F18751727: D19459.id46557.diff
Oct 4 2025, 12:21 PM
F18736622: D19459.id46546.diff
Oct 1 2025, 6:56 AM
F18683867: D19459.id.diff
Sep 26 2025, 8:26 AM
F18615095: D19459.id.diff
Sep 14 2025, 1:54 PM
Subscribers
Restricted Owners Package

Details

Summary

Fixes T13145. The list controllers properly support public access already, but some of the view/detail controllers did not.

Allow logged-out users to browse builds, buildables, plans, etc., provided they can see the corresponding objects.

Test Plan

As a logged-out user, browsed around builds, build plans, logs, etc., without hitting any login pages.

Diff Detail

Repository
rP Phabricator
Branch
harbor1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20355
Build 27644: Run Core Tests
Build 27643: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.Jun 1 2018, 8:54 PM
This revision is now accepted and ready to land.Jun 4 2018, 4:51 PM
This revision was automatically updated to reflect the committed changes.