Page MenuHomePhabricator

Add PhabricatorQueryIterator, for buffered iteration over a CursorPagedPolicyAwareQuery
ClosedPublic

Authored by epriestley on May 14 2018, 4:23 PM.
Tags
None
Referenced Files
F18993461: D19450.diff
Wed, Nov 19, 8:03 AM
F18959029: D19450.diff
Thu, Nov 13, 6:02 AM
F18867083: D19450.diff
Mon, Nov 3, 9:24 PM
F18851184: D19450.id46521.diff
Thu, Oct 30, 10:46 PM
F18831448: D19450.id46521.diff
Sat, Oct 25, 1:11 PM
F18809612: D19450.id46525.diff
Oct 19 2025, 3:33 PM
F18774465: D19450.id.diff
Oct 10 2025, 10:00 AM
F18673926: D19450.diff
Sep 25 2025, 12:34 PM
Subscribers
None

Details

Summary

See D19446. This should make it easier to process larger, more complex result sets in constant memory.

Today, LiskMigrationIterator takes constant memory but can't apply needX() reqeusts or withY(...) constraints.

Using a raw Query can handle this stuff, but requires memory proportional to the size of the result set.

Offer the best of both worlds: constant memory and full access to the power of Query classes.

Test Plan

Used this script to iterate over every commit, saw sensible behavior:

list-commits.php
<?php

require_once 'scripts/init/init-script.php';

$viewer = PhabricatorUser::getOmnipotentUser();

$query = id(new DiffusionCommitQuery())
  ->setViewer($viewer);

$iterator = new PhabricatorQueryIterator($query);
foreach ($iterator as $commit) {
  echo $commit->getID()."\n";
}

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable