Page MenuHomePhabricator

Fix a fatal during breadcrumb construction when viewing a dashboard you don't have permission to view
ClosedPublic

Authored by epriestley on May 14 2018, 3:48 PM.
Tags
None
Referenced Files
F15548685: D19449.id.diff
Sun, Apr 27, 1:26 AM
F15530156: D19449.id46524.diff
Wed, Apr 23, 2:16 AM
F15515721: D19449.id.diff
Fri, Apr 18, 12:56 PM
F15511713: D19449.diff
Thu, Apr 17, 4:53 AM
F15486523: D19449.id.diff
Thu, Apr 10, 8:00 AM
F15484799: D19449.diff
Wed, Apr 9, 8:12 PM
F15442720: D19449.diff
Mar 27 2025, 12:07 AM
F15427272: D19449.id46524.diff
Mar 23 2025, 1:30 PM
Subscribers
None

Details

Summary

Ref PHI662. Viewing a dashboard you don't have permission to view (in the Dashboard application) currently fatals while building crumbs, since we fail to build the ... > Dashboard 123 > ... crumb.

Test Plan
  • Viewed a dashboard I didn't have permission to view in the Dashboards application.
  • Before patch, fatal when calling getID() on a non-object.
  • After patch, sensible policy error page.
  • Viewed a dashboard I can view, saw sensible crumbs.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable