Page MenuHomePhabricator

Fix a fatal during breadcrumb construction when viewing a dashboard you don't have permission to view
ClosedPublic

Authored by epriestley on May 14 2018, 3:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 9:31 PM
Unknown Object (File)
Sun, Nov 17, 12:26 AM
Unknown Object (File)
Fri, Oct 25, 7:56 PM
Unknown Object (File)
Oct 23 2024, 1:48 PM
Unknown Object (File)
Oct 21 2024, 3:46 AM
Unknown Object (File)
Oct 14 2024, 7:57 AM
Unknown Object (File)
Oct 13 2024, 11:52 AM
Unknown Object (File)
Oct 13 2024, 1:48 AM
Subscribers
None

Details

Summary

Ref PHI662. Viewing a dashboard you don't have permission to view (in the Dashboard application) currently fatals while building crumbs, since we fail to build the ... > Dashboard 123 > ... crumb.

Test Plan
  • Viewed a dashboard I didn't have permission to view in the Dashboards application.
  • Before patch, fatal when calling getID() on a non-object.
  • After patch, sensible policy error page.
  • Viewed a dashboard I can view, saw sensible crumbs.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable