Page MenuHomePhabricator

Fix a fatal during breadcrumb construction when viewing a dashboard you don't have permission to view
ClosedPublic

Authored by epriestley on May 14 2018, 3:48 PM.
Tags
None
Referenced Files
F18799165: D19449.id.diff
Fri, Oct 17, 12:16 PM
F18791168: D19449.id46518.diff
Thu, Oct 16, 4:35 AM
F18777206: D19449.id.diff
Sat, Oct 11, 1:18 AM
F18777203: D19449.id46524.diff
Sat, Oct 11, 1:18 AM
F18777192: D19449.diff
Sat, Oct 11, 1:17 AM
F18697546: D19449.diff
Sat, Sep 27, 9:46 AM
F18620324: D19449.diff
Sep 15 2025, 4:54 AM
F18572726: D19449.id46518.diff
Sep 10 2025, 7:14 AM
Subscribers
None

Details

Summary

Ref PHI662. Viewing a dashboard you don't have permission to view (in the Dashboard application) currently fatals while building crumbs, since we fail to build the ... > Dashboard 123 > ... crumb.

Test Plan
  • Viewed a dashboard I didn't have permission to view in the Dashboards application.
  • Before patch, fatal when calling getID() on a non-object.
  • After patch, sensible policy error page.
  • Viewed a dashboard I can view, saw sensible crumbs.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable