Page MenuHomePhabricator

Fix a fatal during breadcrumb construction when viewing a dashboard you don't have permission to view
ClosedPublic

Authored by epriestley on May 14 2018, 3:48 PM.
Tags
None
Referenced Files
F19074655: D19449.id46524.diff
Dec 1 2025, 6:16 AM
F19067234: D19449.id.diff
Nov 30 2025, 7:25 AM
F19040711: D19449.diff
Nov 26 2025, 1:26 PM
F19017778: D19449.diff
Nov 23 2025, 9:11 AM
F18852521: D19449.diff
Oct 31 2025, 9:42 AM
F18846381: D19449.diff
Oct 29 2025, 6:43 PM
F18799165: D19449.id.diff
Oct 17 2025, 12:16 PM
F18791168: D19449.id46518.diff
Oct 16 2025, 4:35 AM
Subscribers
None

Details

Summary

Ref PHI662. Viewing a dashboard you don't have permission to view (in the Dashboard application) currently fatals while building crumbs, since we fail to build the ... > Dashboard 123 > ... crumb.

Test Plan
  • Viewed a dashboard I didn't have permission to view in the Dashboards application.
  • Before patch, fatal when calling getID() on a non-object.
  • After patch, sensible policy error page.
  • Viewed a dashboard I can view, saw sensible crumbs.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable