Fix a fatal during breadcrumb construction when viewing a dashboard you don't have permission to view
ClosedPublic
Actions

Authored by epriestley on May 14 2018, 3:48 PM.

Tags

None

Referenced Files

	F15442720: D19449.diff
	Thu, Mar 27, 12:07 AM

	F15427272: D19449.id46524.diff
	Sun, Mar 23, 1:30 PM

	F15421713: D19449.id46518.diff
	Sat, Mar 22, 1:48 AM

	F15419142: D19449.id46524.diff
	Fri, Mar 21, 3:55 AM

	F15415531: D19449.id46518.diff
	Thu, Mar 20, 6:31 AM

	F15400620: D19449.id.diff
	Mon, Mar 17, 12:56 PM

	F15395309: D19449.diff
	Sun, Mar 16, 5:20 AM

	F15381156: D19449.id46524.diff
	Fri, Mar 14, 6:09 AM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rP29df80b48f16: Fix a fatal during breadcrumb construction when viewing a dashboard you don't…

Summary

Ref PHI662. Viewing a dashboard you don't have permission to view (in the Dashboard application) currently fatals while building crumbs, since we fail to build the ... > Dashboard 123 > ... crumb.

Test Plan

Viewed a dashboard I didn't have permission to view in the Dashboards application.
Before patch, fatal when calling getID() on a non-object.
After patch, sensible policy error page.
Viewed a dashboard I can view, saw sensible crumbs.