Modularize Almanac Binding transactions
ClosedPublic
Actions

Authored by epriestley on Apr 10 2018, 12:15 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T12414: Implement Almanac edit endpoints in Conduit
T13120: Plans: 2018 Week 15 Bonus Content

Commits

rPf62494355daf: Modularize Almanac Binding transactions

Summary

Depends on D19320. Ref T13120. Ref T12414. Move transactions for Almanac Bindings to ModularTransactions.

Test Plan

Created a new binding.
Tried to create a duplicate binding, got an error.
Edited a binding to rebind it to a different device.
Disabled and enabled bindings.
Grepped for AlmanacBindingTransaction:: constants.

When a binding is created, it currently renders a bad "changed the interface from ??? to X" transaction. This is because creation isn't currently using EditEngine. I plan to swap it shortly, which will turn this into a real "Create" transaction and fix the issue.

Diff Detail

Repository

rP Phabricator

Branch

almanac6

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20051
Build 27194: Run Core Tests
Build 27193: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 10 2018, 12:15 PM

Harbormaster completed remote builds in B20051: Diff 46227.Apr 10 2018, 12:16 PM

epriestley requested review of this revision.Apr 10 2018, 12:17 PM

epriestley added a child revision: D19322: Modularize Almanac Network transactions.Apr 10 2018, 12:21 PM

Note that, for now, Bindings have the same issue as Services in D19317: editing properties works correctly, but doesn't render the right transaction stories in the timeline. Since this is just a display issue, I plan to deal with it after converting everything.

amckinley accepted this revision.Apr 10 2018, 3:51 PM

amckinley added inline comments.