Improve argument parsing for "arc patch --revision Dxxx"
ClosedPublic
Actions

Authored by epriestley on Apr 3 2018, 5:50 PM.

Details

Reviewers: None
Maniphest Tasks: T13116: Plans: 2018 Week 14 Bonus Content
Commits: rARCe44a2d3ac0bf: Improve argument parsing for "arc patch --revision Dxxx"

Summary

See PHI527. Ref T13116. The --revision flag currently fails if the argument is in the form D123 instead of 123. Normalize monogram arguments.

Test Plan

Ran arc patch --revision Dxxx, arc patch --revision xxx, arc patch --revision xxx --diff yyy, arc patch; got good behavior on the good ones and sensible error messages on the other ones.

Diff Detail

Repository

rARC Arcanist

Branch

patch1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19979
Build 27093: Run Core Tests
Build 27092: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 3 2018, 5:50 PM

Harbormaster completed remote builds in B19979: Diff 46158.Apr 3 2018, 5:51 PM

epriestley requested review of this revision.Apr 3 2018, 5:51 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 3 2018, 5:56 PM

Closed by commit rARCe44a2d3ac0bf: Improve argument parsing for "arc patch --revision Dxxx" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistPatchWorkflow.php

91 lines

Diff 46158

View Options

src/workflow/ArcanistPatchWorkflow.php

Improve argument parsing for "arc patch --revision Dxxx"ClosedPublicActions