Page MenuHomePhabricator
Differential D19270

Provide comment actions for tokenizer custom fields
ClosedPublic
Actions

Authored by epriestley on Mar 29 2018, 9:06 PM.
Tags
None
Referenced Files
F14843049: D19270.diff
Sun, Feb 2, 3:32 AM
Unknown Object (File)
Sat, Jan 25, 12:52 AM
Unknown Object (File)
Sat, Jan 25, 12:52 AM
Unknown Object (File)
Sat, Jan 25, 12:51 AM
Unknown Object (File)
Tue, Jan 21, 9:44 AM
Unknown Object (File)
Sat, Jan 18, 5:18 AM
Unknown Object (File)
Sun, Jan 5, 10:07 PM
Unknown Object (File)
Dec 29 2024, 5:05 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13114: Plans: 2018 Week 13 Bonus Content
Commits
rP9fbf4ee58c0d: Provide comment actions for tokenizer custom fields
Summary

Ref T13114. See PHI519. An install is interested in modifying a tokenizer custom field from the comment area. Provide this capability.

This patch is fairly narrow but should solve the immediate need.

Test Plan

Added, removed, and modified a tokenizer custom field using the comment action dropdown.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 29 2018, 9:06 PM
Harbormaster completed remote builds in B19949: Diff 46128.Mar 29 2018, 9:07 PM
epriestley requested review of this revision.Mar 29 2018, 9:07 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 29 2018, 9:10 PM
Closed by commit rP9fbf4ee58c0d: Provide comment actions for tokenizer custom fields (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
infrastructure/
customfield/
editor/
34 lines
field/
21 lines
standard/
22 lines

Diff 46129

View Options

src/infrastructure/customfield/editor/PhabricatorCustomFieldEditField.php

Loading...
View Options

src/infrastructure/customfield/field/PhabricatorCustomField.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldTokenizer.php

Loading...
Phabricator · Built by Phacility