Differential D19242

Fix a possible `count(null)` in DifferentialRevisionActionTransaction
ClosedPublic
Actions

Authored by tolbrino on Mar 21 2018, 8:51 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rP73b68bc2a619: Fix a possible `count(null)` in DifferentialRevisionActionTransaction

Summary

This change prevents the following error when using PHP 7.2:

ERROR 2: count(): Parameter must be an array or an object that implements Countable at [/usr/local/lib/php/phabricator/src/applications/differential/xaction/DifferentialRevisionActionTransaction.php:132]

A similar issue was fixed in D18964

Test Plan

Tested in a live system.

Diff Detail

Repository

rP Phabricator

Branch

fix_count_php72

Lint

Lint Passed

Unit

Tests Skipped

Build Status

Buildable 19889
Build 26954: arc lint + arc unit

Event Timeline

tolbrino created this revision.Mar 21 2018, 8:51 AM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMar 21 2018, 8:51 AM

tolbrino requested review of this revision.Mar 21 2018, 8:51 AM

Herald added a subscriber: Korvin. · View Herald TranscriptMar 21 2018, 8:51 AM

Harbormaster completed remote builds in B19889: Diff 46071.Mar 21 2018, 8:51 AM

Thanks!

This revision is now accepted and ready to land.Mar 21 2018, 2:39 PM

Closed by commit rP73b68bc2a619: Fix a possible `count(null)` in DifferentialRevisionActionTransaction (authored by tolbrino, committed by epriestley). · Explain WhyMar 21 2018, 2:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

xaction/

DifferentialRevisionActionTransaction.php

2 lines

Diff 46071

View Options

src/applications/differential/xaction/DifferentialRevisionActionTransaction.php

Fix a possible `count(null)` in DifferentialRevisionActionTransactionClosedPublicActions