Differential D19214

Use "-dispose background" to improve reassembly of GIFs with transparency
ClosedPublic
Actions

Authored by epriestley on Mar 13 2018, 4:07 PM.

Details

Reviewers: None
Maniphest Tasks: T5741: Transparent meme animated gifs show up with a black background
Commits: rPa4a390fe2d9f: Use "-dispose background" to improve reassembly of GIFs with transparency

Summary

Fixes T5741. We break GIFs apart with "-coalesce" which completely rasterizes each frame, but stitch them back together without specifying "-dispose".

This produces the default "-dispose none" behavior, which causes GIF frames to "pile up" if they contain transparency.

Instead, use "-dispose background" so that the previous frame is erased before each new frame is drawn.

Test Plan

See T5741 for additional details.

Diff Detail

Repository

rP Phabricator

Branch

dispose

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19829
Build 26867: Run Core Tests
Build 26866: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 13 2018, 4:07 PM

Harbormaster completed remote builds in B19829: Diff 46011.Mar 13 2018, 4:08 PM

epriestley requested review of this revision.Mar 13 2018, 4:08 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 13 2018, 4:19 PM

Closed by commit rPa4a390fe2d9f: Use "-dispose background" to improve reassembly of GIFs with transparency (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T5741: Transparent meme animated gifs show up with a black background.Mar 13 2018, 4:27 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

macro/

engine/

PhabricatorMemeEngine.php

12 lines

Diff 46011

View Options

src/applications/macro/engine/PhabricatorMemeEngine.php

Use "-dispose background" to improve reassembly of GIFs with transparencyClosedPublicActions