Differential D19209

Dynamically composite favicons from customizable sources
ClosedPublic
Actions

Authored by epriestley on Mar 12 2018, 10:14 PM.

Details

Reviewers: None
Maniphest Tasks: T13103: Document favicon customization and validate the "ui.favicons" configuration option
Commits: rP3c4f31e4b921: Dynamically composite favicons from customizable sources

Summary

Ref T13103. Make favicons customizable, and perform dynamic compositing to add marker to indicate things like "unread messages".

Test Plan

Viewed favicons in Safari, Firefox and Chrome. With unread messages, saw pink dot composited into icon.

Diff Detail

Repository

rP Phabricator

Branch

favicon1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19818
Build 26850: Run Core Tests
Build 26849: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 12 2018, 10:14 PM

Harbormaster completed remote builds in B19818: Diff 46000.Mar 12 2018, 10:15 PM

epriestley requested review of this revision.Mar 12 2018, 10:15 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 12 2018, 10:28 PM

Closed by commit rP3c4f31e4b921: Dynamically composite favicons from customizable sources (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D19212: Allow PhutilSortVector to self-sort.Mar 13 2018, 2:00 PM

epriestley mentioned this in rPHUa3e02f01c34f: Allow PhutilSortVector to self-sort.Mar 13 2018, 2:01 PM

Revision Contents
Changeset List

Path

Size

	resources/	builtin/	favicon/
	webroot/	rsrc/	favicons/

	default-120x120.png
	apple-touch-icon-120x120.png

	default-128x128.png
	favicon-128.png

	default-152x152.png
	apple-touch-icon-152x152.png

	default-76x76.png
	apple-touch-icon-76x76.png

resources/

builtin/

favicon/

dot-pink-64x64.png

dot-red-64x64.png

celerity/

map.php

21 lines

src/

__phutil_library_map__.php

6 lines

applications/

config/

option/

PhabricatorUIConfigOptions.php

4 lines

files/

favicon/

PhabricatorFaviconRef.php

447 lines

PhabricatorFaviconRefQuery.php

55 lines

storage/

PhabricatorFile.php

1 line

system/

application/

PhabricatorSystemApplication.php

1 line

controller/

PhabricatorSystemFaviconController.php

view/

page/

PhabricatorBarePageView.php

114 lines

menu/

PhabricatorMainMenuView.php

47 lines

webroot/

favicon.ico

rsrc/

favicons/

apple-touch-icon-114x114.png

apple-touch-icon-120x120.png

apple-touch-icon-144x144.png

apple-touch-icon-152x152.png

apple-touch-icon-57x57.png

apple-touch-icon-60x60.png

apple-touch-icon-72x72.png

apple-touch-icon-76x76.png

Diff 46000

View Options

resources/builtin/favicon/default-120x120.png

View Options

resources/builtin/favicon/default-128x128.png

View Options

resources/builtin/favicon/default-152x152.png

View Options

resources/builtin/favicon/default-76x76.png

View Options

resources/builtin/favicon/dot-pink-64x64.png

View Options

resources/builtin/favicon/dot-red-64x64.png

View Options

resources/celerity/map.php

View Options

src/__phutil_library_map__.php

View Options

src/applications/config/option/PhabricatorUIConfigOptions.php

View Options

src/applications/files/favicon/PhabricatorFaviconRef.php

View Options

src/applications/files/favicon/PhabricatorFaviconRefQuery.php

View Options

src/applications/files/storage/PhabricatorFile.php

View Options

src/applications/system/application/PhabricatorSystemApplication.php

View Options

src/applications/system/controller/PhabricatorSystemFaviconController.php

View Options

src/view/page/PhabricatorBarePageView.php

View Options

src/view/page/menu/PhabricatorMainMenuView.php

View Options

webroot/favicon.ico

View Options

webroot/rsrc/favicons/apple-touch-icon-114x114.png

View Options

webroot/rsrc/favicons/apple-touch-icon-120x120.png

View Options

webroot/rsrc/favicons/apple-touch-icon-144x144.png

View Options

webroot/rsrc/favicons/apple-touch-icon-152x152.png

View Options

webroot/rsrc/favicons/apple-touch-icon-57x57.png

View Options

webroot/rsrc/favicons/apple-touch-icon-60x60.png

View Options

webroot/rsrc/favicons/apple-touch-icon-72x72.png

View Options

webroot/rsrc/favicons/apple-touch-icon-76x76.png

View Options

webroot/rsrc/favicons/favicon-128.png

View Options

webroot/rsrc/favicons/favicon-196x196.png

View Options

webroot/rsrc/favicons/favicon-32x32.png

View Options

webroot/rsrc/favicons/favicon-96x96.png

View Options

webroot/rsrc/favicons/favicon-mention.ico

View Options

webroot/rsrc/favicons/favicon-message.ico

View Options

webroot/rsrc/favicons/favicon.ico

View Options

webroot/rsrc/favicons/mstile-144x144.png

View Options

webroot/rsrc/favicons/mstile-150x150.png

View Options

webroot/rsrc/favicons/mstile-310x150.png

View Options

webroot/rsrc/favicons/mstile-310x310.png

View Options

webroot/rsrc/favicons/mstile-70x70.png

Dynamically composite favicons from customizable sourcesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 46000

resources/builtin/favicon/default-120x120.png

resources/builtin/favicon/default-128x128.png

resources/builtin/favicon/default-152x152.png

resources/builtin/favicon/default-76x76.png

resources/builtin/favicon/dot-pink-64x64.png

resources/builtin/favicon/dot-red-64x64.png

resources/celerity/map.php

src/__phutil_library_map__.php

src/applications/config/option/PhabricatorUIConfigOptions.php

src/applications/files/favicon/PhabricatorFaviconRef.php

src/applications/files/favicon/PhabricatorFaviconRefQuery.php

src/applications/files/storage/PhabricatorFile.php

src/applications/system/application/PhabricatorSystemApplication.php

src/applications/system/controller/PhabricatorSystemFaviconController.php

src/view/page/PhabricatorBarePageView.php

src/view/page/menu/PhabricatorMainMenuView.php

webroot/favicon.ico

webroot/rsrc/favicons/apple-touch-icon-114x114.png

webroot/rsrc/favicons/apple-touch-icon-120x120.png

webroot/rsrc/favicons/apple-touch-icon-144x144.png

webroot/rsrc/favicons/apple-touch-icon-152x152.png

webroot/rsrc/favicons/apple-touch-icon-57x57.png

webroot/rsrc/favicons/apple-touch-icon-60x60.png

webroot/rsrc/favicons/apple-touch-icon-72x72.png

webroot/rsrc/favicons/apple-touch-icon-76x76.png

webroot/rsrc/favicons/favicon-128.png

webroot/rsrc/favicons/favicon-196x196.png

webroot/rsrc/favicons/favicon-32x32.png

webroot/rsrc/favicons/favicon-96x96.png

webroot/rsrc/favicons/favicon-mention.ico

webroot/rsrc/favicons/favicon-message.ico

webroot/rsrc/favicons/favicon.ico

webroot/rsrc/favicons/mstile-144x144.png

webroot/rsrc/favicons/mstile-150x150.png

webroot/rsrc/favicons/mstile-310x150.png

webroot/rsrc/favicons/mstile-310x310.png

webroot/rsrc/favicons/mstile-70x70.png

Dynamically composite favicons from customizable sources
ClosedPublic
Actions

Revision Contents
Changeset List