Differential D19198

Remove some old image transform code with no callsites
ClosedPublic
Actions

Authored by epriestley on Mar 8 2018, 4:31 PM.

Tags

None

Referenced Files

	F13863969: D19198.diff
	Tue, Oct 1, 8:13 AM

	Unknown Object (File)
	Tue, Sep 17, 9:24 AM

	Unknown Object (File)
	Sat, Sep 14, 11:11 PM

	Unknown Object (File)
	Fri, Sep 6, 2:46 AM

	Unknown Object (File)
	Thu, Sep 5, 1:43 PM

	Unknown Object (File)
	Aug 31 2024, 4:23 PM

	Unknown Object (File)
	Aug 30 2024, 9:17 AM

	Unknown Object (File)
	Aug 29 2024, 12:07 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T5258: Memes use older image transform code without modern error handling
T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy
Commits: rPa099a0626532: Remove some old image transform code with no callsites

Summary

Ref T13101. Ref T5258. This old image transform code no longer has callsites.

Test Plan

Grepped for removed methods, no hits.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 8 2018, 4:31 PM

Harbormaster completed remote builds in B19796: Diff 45979.Mar 8 2018, 4:32 PM

epriestley requested review of this revision.Mar 8 2018, 4:32 PM

epriestley added a child revision: D19200: PhabricatorMemeEngine HA HA HA HA.Mar 8 2018, 5:38 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 8 2018, 7:04 PM

Closed by commit rPa099a0626532: Remove some old image transform code with no callsites (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

files/

PhabricatorImageTransformer.php

75 lines

Diff 45986

View Options

src/applications/files/PhabricatorImageTransformer.php

Remove some old image transform code with no callsitesClosedPublicActions