Page MenuHomePhabricator
Differential D19198

Remove some old image transform code with no callsites
ClosedPublic
Actions

Authored by epriestley on Mar 8 2018, 4:31 PM.
Tags
None
Referenced Files
F15489897: D19198.id45986.diff
Fri, Apr 11, 1:15 PM
F15489896: D19198.id45979.diff
Fri, Apr 11, 1:15 PM
F15489895: D19198.id.diff
Fri, Apr 11, 1:15 PM
F15487185: D19198.diff
Thu, Apr 10, 11:51 AM
F15475632: D19198.id45986.diff
Sun, Apr 6, 9:06 PM
F15475631: D19198.id45979.diff
Sun, Apr 6, 9:06 PM
F15475630: D19198.id.diff
Sun, Apr 6, 9:06 PM
F15475049: D19198.diff
Sun, Apr 6, 3:09 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T5258: Memes use older image transform code without modern error handling
T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy
Commits
rPa099a0626532: Remove some old image transform code with no callsites
Summary

Ref T13101. Ref T5258. This old image transform code no longer has callsites.

Test Plan

Grepped for removed methods, no hits.

Diff Detail

Repository
rP Phabricator
Branch
meme2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19796
Build 26819: Run Core Tests
Build 26818: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 8 2018, 4:31 PM
Harbormaster completed remote builds in B19796: Diff 45979.Mar 8 2018, 4:32 PM
epriestley requested review of this revision.Mar 8 2018, 4:32 PM
epriestley added a child revision: D19200: PhabricatorMemeEngine HA HA HA HA.Mar 8 2018, 5:38 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 8 2018, 7:04 PM
Closed by commit rPa099a0626532: Remove some old image transform code with no callsites (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
files/
75 lines

Diff 45979

View Options

src/applications/files/PhabricatorImageTransformer.php

Loading...
Phabricator · Built by Phacility