Paths

Table of Contentst

Differential D19195

Don't require prototypes for "{image ...}"
ClosedPublic
Actions

Authored by epriestley on Mar 8 2018, 3:00 PM.

Tags

None

Referenced Files

	F15523236: D19195.diff
	Mon, Apr 21, 12:03 AM

	F15502876: D19195.id45974.diff
	Mon, Apr 14, 5:14 AM

	F15488841: D19195.diff
	Fri, Apr 11, 3:19 AM

	F15452075: D19195.id45970.diff
	Sat, Mar 29, 1:34 AM

	F15441842: D19195.id.diff
	Wed, Mar 26, 8:17 PM

	F15435039: D19195.diff
	Mar 25 2025, 6:36 AM

	F15426966: D19195.diff
	Mar 23 2025, 11:55 AM

	Unknown Object (File)
	Feb 21 2025, 3:34 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T4190: Rebuild remarkup image proxying
Commits: rP6095d889987d: Don't require prototypes for "{image ...}"

Summary

Depends on D19194. Fixes T4190. This should be in good-enough shape now to release and support more generally.

Test Plan

Used {image ...} in remarkup.

Diff Detail

Repository

rP Phabricator

Branch

image4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19787
Build 26807: Run Core Tests
Build 26806: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 8 2018, 3:00 PM

Harbormaster completed remote builds in B19787: Diff 45970.Mar 8 2018, 3:01 PM

epriestley requested review of this revision.Mar 8 2018, 3:01 PM

epriestley mentioned this in T4190: Rebuild remarkup image proxying.Mar 8 2018, 3:02 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 8 2018, 3:04 PM

Closed by commit rP6095d889987d: Don't require prototypes for "{image ...}" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

files/

controller/

PhabricatorFileImageProxyController.php

34 lines

Diff 45970

View Options

src/applications/files/controller/PhabricatorFileImageProxyController.php

Don't require prototypes for "{image ...}"ClosedPublicActions