Paths

Table of Contentst

Differential D19194

When rendering "{image ...}" images, check the cache and just render a direct "<img />" tag if possible
ClosedPublic
Actions

Authored by epriestley on Mar 8 2018, 2:51 PM.

Tags

None

Referenced Files

	F15388918: D19194.diff
	Sat, Mar 15, 4:39 AM

	Unknown Object (File)
	Fri, Feb 21, 3:34 PM

	Unknown Object (File)
	Mon, Feb 17, 2:45 AM

	Unknown Object (File)
	Feb 14 2025, 2:39 AM

	Unknown Object (File)
	Feb 9 2025, 5:35 PM

	Unknown Object (File)
	Feb 9 2025, 5:39 AM

	Unknown Object (File)
	Feb 9 2025, 5:39 AM

	Unknown Object (File)
	Feb 9 2025, 5:39 AM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T4190: Rebuild remarkup image proxying
T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy
Commits: rPb30535a36f5f: When rendering "{image ...}" images, check the cache and just render a direct…

Summary

Depends on D19193. Ref T13101. Fixes T4190. Before we render a fancy AJAX placeholder, check if we already have a valid cache for the image. If we do, render a direct <img /> tag. This is a little cleaner and, e.g., avoids flicker in Safari, at least.

Test Plan

Rendered {image ...} rules in remarkup with new and existing URIs.

Diff Detail

Repository

Branch

image3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19786
Build 26805: Run Core Tests
Build 26804: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 8 2018, 2:51 PM

Harbormaster completed remote builds in B19786: Diff 45969.Mar 8 2018, 2:53 PM

epriestley requested review of this revision.Mar 8 2018, 2:53 PM

epriestley added a child revision: D19195: Don't require prototypes for "{image ...}".Mar 8 2018, 3:00 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 8 2018, 3:04 PM

Closed by commit rPb30535a36f5f: When rendering "{image ...}" images, check the cache and just render a direct… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

files/

markup/

PhabricatorImageRemarkupRule.php

68 lines

Diff 45969

src/applications/files/markup/PhabricatorImageRemarkupRule.php

Loading...