Page MenuHomePhabricator

Fix broken suggestion/validation for Owners paths in repositories with short names
ClosedPublic

Authored by epriestley on Mar 8 2018, 1:33 AM.
Tags
None
Referenced Files
F15418971: D19190.id45961.diff
Fri, Mar 21, 2:45 AM
F15414723: D19190.diff
Thu, Mar 20, 2:09 AM
F15397949: D19190.id45961.diff
Sun, Mar 16, 11:03 PM
F15396805: D19190.diff
Sun, Mar 16, 4:23 PM
F15392114: D19190.id45961.diff
Sat, Mar 15, 1:17 PM
F15353028: D19190.id45961.diff
Mon, Mar 10, 7:43 PM
F15336418: D19190.diff
Sat, Mar 8, 6:48 PM
F15333415: D19190.id45961.diff
Sat, Mar 8, 2:17 AM
Subscribers
None

Details

Summary

Depends on D19189. Ref T12590. The "validate" and "complete" endpoints for this UI could incorrectly return redirect responses. These aren't critical to the behavior of Owners, but they're nice to have, and shouldn't redirect.

Instead, skip the canonicalizing redirect for AJAX requests.

Test Plan

Edited Owners paths in a repository with a short name, got completion/validation again.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable