Differential D19190

Fix broken suggestion/validation for Owners paths in repositories with short names
ClosedPublic
Actions

Authored by epriestley on Mar 8 2018, 1:33 AM.

Details

Reviewers: None
Maniphest Tasks: T12590: Owners expects users to choose a repository with a <select /> that lists every repository in ID order
Commits: rPb41a0e6ddda3: Fix broken suggestion/validation for Owners paths in repositories with short…

Summary

Depends on D19189. Ref T12590. The "validate" and "complete" endpoints for this UI could incorrectly return redirect responses. These aren't critical to the behavior of Owners, but they're nice to have, and shouldn't redirect.

Instead, skip the canonicalizing redirect for AJAX requests.

Test Plan

Edited Owners paths in a repository with a short name, got completion/validation again.

Diff Detail

Repository

rP Phabricator

Branch

owners2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19778
Build 26792: Run Core Tests
Build 26791: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 8 2018, 1:33 AM

Harbormaster completed remote builds in B19778: Diff 45961.Mar 8 2018, 1:34 AM

epriestley requested review of this revision.Mar 8 2018, 1:34 AM

epriestley added a child revision: D19191: Use a tokenizer, not a gigantic poorly-ordered "<select />", to choose repositories in Owners.Mar 8 2018, 2:22 AM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 8 2018, 2:31 AM

Closed by commit rPb41a0e6ddda3: Fix broken suggestion/validation for Owners paths in repositories with short… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionController.php

17 lines

Diff 45961

View Options

src/applications/diffusion/controller/DiffusionController.php

Fix broken suggestion/validation for Owners paths in repositories with short namesClosedPublicActions