Page MenuHomePhabricator

Add Owners Package support for "Commit Hook: Content" Herald rules
ClosedPublic

Authored by epriestley on Feb 16 2018, 12:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 15, 5:16 PM
Unknown Object (File)
Sun, Apr 14, 12:13 PM
Unknown Object (File)
Sun, Apr 14, 12:13 PM
Unknown Object (File)
Sun, Apr 14, 10:59 AM
Unknown Object (File)
Fri, Apr 12, 12:44 AM
Unknown Object (File)
Thu, Apr 11, 8:39 AM
Unknown Object (File)
Sat, Mar 30, 6:54 PM
Unknown Object (File)
Sat, Mar 30, 6:54 PM
Subscribers
None

Details

Summary

See PHI370. Support the "Affected packages" and "Affected package owners" Herald fields in pre-commit hooks.

I believe there's no technical reason these fields aren't supported and this was just overlooked.

Test Plan

Wrote a rule which makes use of the new fields, pushed commits through it. Checked transcripts and saw sensible-looking values.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 16 2018, 5:49 PM
This revision was automatically updated to reflect the committed changes.