Page MenuHomePhabricator

Add Owners Package support for "Commit Hook: Content" Herald rules
ClosedPublic

Authored by epriestley on Feb 16 2018, 12:44 PM.
Tags
None
Referenced Files
F18923030: D19104.diff
Nov 9 2025, 4:11 PM
F18842922: D19104.id45788.diff
Oct 28 2025, 7:43 PM
F18753249: D19104.id.diff
Oct 4 2025, 6:00 PM
F18746485: D19104.diff
Oct 3 2025, 12:36 PM
F18702386: D19104.id45788.diff
Sep 27 2025, 11:56 PM
F18608564: D19104.id45782.diff
Sep 14 2025, 1:20 AM
F18566598: D19104.id.diff
Sep 9 2025, 2:46 PM
F18502188: D19104.diff
Sep 4 2025, 10:15 PM
Subscribers
None

Details

Summary

See PHI370. Support the "Affected packages" and "Affected package owners" Herald fields in pre-commit hooks.

I believe there's no technical reason these fields aren't supported and this was just overlooked.

Test Plan

Wrote a rule which makes use of the new fields, pushed commits through it. Checked transcripts and saw sensible-looking values.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 16 2018, 5:49 PM
This revision was automatically updated to reflect the committed changes.