When "phabricator.silent" is enabled, don't call webhooks
ClosedPublic
Actions

Authored by epriestley on Feb 14 2018, 7:14 PM.

Details

Reviewers: None
Maniphest Tasks: T13078: `phabricator.silent` should also silence remote builds and webhooks
Commits: rPa2453706abf1: When "phabricator.silent" is enabled, don't call webhooks

Summary

Ref T13078. The phabricator.silent configuration flag should disable webhook calls, since this is consistent with the documented and desired behavior.

Test Plan

Enabled phabricator.silent, made test hook calls, saw them fail with a "silent" failure reason.

Diff Detail

Repository

rP Phabricator

Branch

silent1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19546
Build 26451: Run Core Tests
Build 26450: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 14 2018, 7:14 PM

Harbormaster completed remote builds in B19546: Diff 45742.Feb 14 2018, 7:15 PM

epriestley requested review of this revision.Feb 14 2018, 7:15 PM

epriestley added a child revision: D19085: Make "phabricator.silent" disable build steps which rely on external services.Feb 14 2018, 7:36 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 14 2018, 7:40 PM

Closed by commit rPa2453706abf1: When "phabricator.silent" is enabled, don't call webhooks (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

worker/

HeraldWebhookWorker.php

7 lines

Diff 45742

View Options

src/applications/herald/worker/HeraldWebhookWorker.php

When "phabricator.silent" is enabled, don't call webhooksClosedPublicActions