Page MenuHomePhabricator

Give Drydock Leases more modern status treatment
ClosedPublic

Authored by epriestley on Feb 13 2018, 1:14 PM.
Tags
None
Referenced Files
F14078330: D19074.diff
Fri, Nov 22, 3:15 AM
Unknown Object (File)
Tue, Nov 19, 3:02 PM
Unknown Object (File)
Fri, Nov 15, 3:13 AM
Unknown Object (File)
Mon, Nov 11, 5:46 AM
Unknown Object (File)
Sun, Nov 10, 10:08 PM
Unknown Object (File)
Sun, Nov 10, 10:03 PM
Unknown Object (File)
Thu, Nov 7, 3:36 AM
Unknown Object (File)
Mon, Nov 4, 7:27 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19073. Ref T13073. Give leases a normal header tag and try to wrangle their status constants a bit.

Also, try to capture the "status class" pattern a bit. Since we target PHP 5.2.3 we can't use static:: so the actual subclass is kind of a mess. Not exactly sure if I want to stick with this or not. We could consider targeting PHP 5.3.0 instead to get static:: / late static binding.

Test Plan

Viewed leases and lease lists, saw better and more conventional status information.

Diff Detail

Repository
rP Phabricator
Branch
dry5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19521
Build 26416: Run Core Tests
Build 26415: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.Feb 13 2018, 1:14 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 13 2018, 9:16 PM
This revision was automatically updated to reflect the committed changes.