Page MenuHomePhabricator

Give Drydock Leases more modern status treatment
ClosedPublic

Authored by epriestley on Feb 13 2018, 1:14 PM.
Tags
None
Referenced Files
F19084025: D19074.id.diff
Dec 2 2025, 2:11 PM
F19078239: D19074.diff
Dec 1 2025, 5:35 PM
F18878336: D19074.id45730.diff
Nov 6 2025, 4:59 PM
F18853032: D19074.id.diff
Oct 31 2025, 1:51 PM
F18850785: D19074.diff
Oct 30 2025, 7:21 PM
F18806451: D19074.diff
Oct 18 2025, 7:34 PM
F18806439: D19074.id45730.diff
Oct 18 2025, 7:29 PM
F18788768: D19074.id.diff
Oct 15 2025, 6:27 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19073. Ref T13073. Give leases a normal header tag and try to wrangle their status constants a bit.

Also, try to capture the "status class" pattern a bit. Since we target PHP 5.2.3 we can't use static:: so the actual subclass is kind of a mess. Not exactly sure if I want to stick with this or not. We could consider targeting PHP 5.3.0 instead to get static:: / late static binding.

Test Plan

Viewed leases and lease lists, saw better and more conventional status information.

Diff Detail

Repository
rP Phabricator
Branch
dry5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19521
Build 26416: Run Core Tests
Build 26415: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.Feb 13 2018, 1:14 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 13 2018, 9:16 PM
This revision was automatically updated to reflect the committed changes.