Page MenuHomePhabricator

Allow a HarbormasterBuildMessage to be sent to any object
ClosedPublic

Authored by epriestley on Feb 12 2018, 6:25 PM.

Details

Summary

See T13054. This prepares for Buildables to be sent messages ("attach", "done scheduling builds") to fix races between Harbormaster and Differential.

The buildTargetPHID is replaced with a recipientPHID in the API. An additional change will fix the storage.

In the future, this table could probably also replace HarbormasterBuildCommand now, which is approximately the same bus, but for Builds.

Test Plan

Viewed builds with messages. Sent messages with harbormaster.sendmessage. Processed messages with bin/phd debug task.

Diff Detail

Repository
rP Phabricator
Branch
hrace1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19501
Build 26384: Run Core Tests
Build 26383: arc lint + arc unit