Page MenuHomePhabricator
Differential D19057

Completely remove the legacy hunk table
ClosedPublic
Actions

Authored by epriestley on Feb 10 2018, 8:11 PM.
Tags
None
Referenced Files
F18785062: D19057.id.diff
Mon, Oct 13, 5:55 PM
F18684380: D19057.diff
Sep 26 2025, 9:19 AM
F18682284: D19057.diff
Sep 26 2025, 5:39 AM
F18656504: D19057.id45685.diff
Sep 22 2025, 10:43 PM
F18618756: D19057.id45690.diff
Sep 15 2025, 12:51 AM
F18509292: D19057.id.diff
Sep 5 2025, 3:20 AM
F18502124: D19057.diff
Sep 4 2025, 10:13 PM
F18324934: D19057.id45685.diff
Aug 24 2025, 8:00 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T8475: Clean up remnants of old Differential hunk storage
T13054: Plans: Harbormaster Interactions with Differential / Chaos Reduction
Commits
rPf43d08c2bbe6: Completely remove the legacy hunk table
Summary

Depends on D19056. Fixes T8475. Ref T13054. Merges "ModernHunk" back into "Hunk".

Test Plan

Grepped for modernhunk. Reviewed revisions. Created a new revision. Used bin/differential migrate-hunk to migrate hunks between storage formats and back.

Diff Detail

Repository
rP Phabricator
Branch
hunk2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19487
Build 26364: Run Core Tests
Build 26363: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 10 2018, 8:11 PM
Harbormaster completed remote builds in B19487: Diff 45685.Feb 10 2018, 8:12 PM
epriestley requested review of this revision.Feb 10 2018, 8:12 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 11 2018, 12:12 AM
Closed by commit rPf43d08c2bbe6: Completely remove the legacy hunk table (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 45685

View Options

resources/sql/autopatches/20161213.diff.01.hunks.php

Loading...
View Options

resources/sql/autopatches/20180210.hunk.02.renamemodern.sql

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/engine/DifferentialDiffExtractionEngine.php

Loading...
View Options

src/applications/differential/management/PhabricatorDifferentialMigrateHunkWorkflow.php

Loading...
View Options

src/applications/differential/parser/__tests__/DifferentialChangesetParserTestCase.php

Loading...
View Options

src/applications/differential/parser/__tests__/DifferentialHunkParserTestCase.php

Loading...
View Options

src/applications/differential/query/DifferentialHunkQuery.php

Loading...
View Options

src/applications/differential/storage/DifferentialChangeset.php

Loading...
View Options

src/applications/differential/storage/DifferentialDiff.php

Loading...
View Options

src/applications/differential/storage/DifferentialHunk.php

Loading...
View Options

src/applications/differential/storage/DifferentialModernHunk.php

Loading...
View Options

src/applications/differential/storage/__tests__/DifferentialHunkTestCase.php

Loading...
Phabricator · Built by Phacility