Page MenuHomePhabricator
Differential D18977

Fix a missing getSSHUser() callsite
ClosedPublic
Actions

Authored by epriestley on Jan 31 2018, 7:30 PM.
Tags
None
Referenced Files
F18776090: D18977.id.diff
Fri, Oct 10, 9:09 PM
F18768808: D18977.id45511.diff
Wed, Oct 8, 5:29 AM
F18750234: D18977.id.diff
Oct 4 2025, 7:02 AM
F18742171: D18977.diff
Oct 2 2025, 5:50 PM
F18700672: D18977.diff
Sep 27 2025, 3:36 PM
F18670571: D18977.diff
Sep 25 2025, 12:44 AM
F18647965: D18977.id45524.diff
Sep 19 2025, 3:23 PM
F18629968: D18977.diff
Sep 16 2025, 10:24 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rP4757ff224c7f: (stable) Fix a missing getSSHUser() callsite
rPf535981c0d61: Fix a missing getSSHUser() callsite
Summary

See https://discourse.phabricator-community.org/t/after-upgrade-git-lfs-push-ends-up-in-call-to-undefined-method-on-diffusion-git-lfs-authenticate-workflow/1047/1.

I renamed this method in D18912 but missed this callsite since the workflow doesn't live alongside the other ones.

Test Plan

Ran git push in an LFS repository over SSH. Before: fatal; after: clean push.

Diff Detail

Repository
rP Phabricator
Branch
lfsuser1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19300
Build 26082: Run Core Tests
Build 26081: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 31 2018, 7:30 PM
Harbormaster completed remote builds in B19300: Diff 45511.Jan 31 2018, 7:31 PM
epriestley requested review of this revision.Jan 31 2018, 7:31 PM
amckinley accepted this revision.Jan 31 2018, 8:32 PM
This revision is now accepted and ready to land.Jan 31 2018, 8:32 PM
Closed by commit rPf535981c0d61: Fix a missing getSSHUser() callsite (authored by epriestley). · Explain WhyJan 31 2018, 11:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
gitlfs/
2 lines

Diff 45511

View Options

src/applications/diffusion/gitlfs/DiffusionGitLFSAuthenticateWorkflow.php

Loading...
Phabricator · Built by Phacility