Page MenuHomePhabricator
Differential D18977

Fix a missing getSSHUser() callsite
ClosedPublic
Actions

Authored by epriestley on Jan 31 2018, 7:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 6, 2:02 AM
Unknown Object (File)
Thu, Sep 5, 12:42 AM
Unknown Object (File)
Sun, Sep 1, 10:37 AM
Unknown Object (File)
Thu, Aug 29, 2:50 PM
Unknown Object (File)
Wed, Aug 28, 7:30 PM
Unknown Object (File)
Sun, Aug 25, 10:50 AM
Unknown Object (File)
Thu, Aug 22, 5:17 AM
Unknown Object (File)
Aug 21 2024, 3:13 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rP4757ff224c7f: (stable) Fix a missing getSSHUser() callsite
rPf535981c0d61: Fix a missing getSSHUser() callsite
Summary

See https://discourse.phabricator-community.org/t/after-upgrade-git-lfs-push-ends-up-in-call-to-undefined-method-on-diffusion-git-lfs-authenticate-workflow/1047/1.

I renamed this method in D18912 but missed this callsite since the workflow doesn't live alongside the other ones.

Test Plan

Ran git push in an LFS repository over SSH. Before: fatal; after: clean push.

Diff Detail

Repository
rP Phabricator
Branch
lfsuser1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19300
Build 26082: Run Core Tests
Build 26081: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 31 2018, 7:30 PM
Harbormaster completed remote builds in B19300: Diff 45511.Jan 31 2018, 7:31 PM
epriestley requested review of this revision.Jan 31 2018, 7:31 PM
amckinley accepted this revision.Jan 31 2018, 8:32 PM
This revision is now accepted and ready to land.Jan 31 2018, 8:32 PM
Closed by commit rPf535981c0d61: Fix a missing getSSHUser() callsite (authored by epriestley). · Explain WhyJan 31 2018, 11:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
gitlfs/
2 lines

Diff 45511

View Options

src/applications/diffusion/gitlfs/DiffusionGitLFSAuthenticateWorkflow.php

Loading...
Phabricator · Built by Phacility